From owner-cvs-all Thu May 2 15:39:33 2002 Delivered-To: cvs-all@freebsd.org Received: from rover.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 025C037B417; Thu, 2 May 2002 15:39:20 -0700 (PDT) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.11.3/8.11.3) with ESMTP id g42MdJ603982; Thu, 2 May 2002 16:39:19 -0600 (MDT) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost [127.0.0.1]) by harmony.village.org (8.11.6/8.11.6) with ESMTP id g42MdGr04255; Thu, 2 May 2002 16:39:18 -0600 (MDT) (envelope-from imp@harmony.village.org) Message-Id: <200205022239.g42MdGr04255@harmony.village.org> To: Bruce Evans Subject: Re: cvs commit: src/sys/conf kmod.mk Cc: Dima Dorfman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-reply-to: Your message of "Fri, 03 May 2002 03:31:49 +1000." <20020503032719.G4775-100000@gamplex.bde.org> References: <20020503032719.G4775-100000@gamplex.bde.org> Date: Thu, 02 May 2002 16:39:16 -0600 From: Warner Losh Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020503032719.G4775-100000@gamplex.bde.org> Bruce Evans writes: : > > +.if !exists(/usr/sbin/kldxref) : > > +NO_XREF=yes : > > +.endif : : This is broken. kldxref might be in $PATH but not in /usr/sbin, or vice : versa. True. However, it breaks a case I don't care about. Until make gets a exists_in_path(foo), this is a reasonable compromise. : > > .if !defined(NO_XREF) : : If a non-broken existence test ifdef exists, why not write it here directly. I didn't want to remove NO_XREF, but rather just use it. : I agree. Ignoring errors in Makefiles is a bug. Yes. It even seems to work. :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message