Date: Tue, 9 Jan 2018 11:03:35 -0700 From: Adam Weinberger <adamw@adamw.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, v@fatpipi.com, Jochen Neumeister <joneum@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458000 - head/www/nginx Message-ID: <825D5BD5-38D0-4F96-AEEE-2FA483F9D2BC@adamw.org> In-Reply-To: <20180109123546.GA9882@FreeBSD.org> References: <201801031933.w03JXLGa033758@repo.freebsd.org> <CAB_qb6_q=ZQdu5Mc3ynSDXycFZdzBy62wf20iZuBcXR2rMr1wQ@mail.gmail.com> <a521343e-219a-340e-5e21-e65277ca8ede@FreeBSD.org> <20180106134130.GA39725@FreeBSD.org> <DFEBB38E-4DB0-4190-B078-B94C2F442EA5@adamw.org> <20180106182537.GA78102@FreeBSD.org> <20180109123546.GA9882@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 9 Jan, 2018, at 5:35, Sergey A. Osokin <osa@FreeBSD.org> wrote: > > Hello, > > is there any update? > > Thanks. Hi Sergey, Sorry, but I can't give you a good answer on why the change was or wasn't discussed, and why people were or weren't notified about it in advance. It was policy long before it was written into the PHB, and that occurred in r43772, 3 years 11 months ago. At the end of the day, it's simply the only mechanism we have to ensure that users' installations match what we have in the repo. Past that I'm not really sure how to give you a satisfactory answer your question. If the policy were enacted a few months ago, I could provide insight, but we're talking about something that's been policy for 5+ years. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org > > -- > Sergey A. Osokin > > On Sat, Jan 06, 2018 at 06:25:37PM +0000, Sergey A. Osokin wrote: >> On Sat, Jan 06, 2018 at 08:15:16AM -0700, Adam Weinberger wrote: >>>> On 6 Jan, 2018, at 6:41, Sergey A. Osokin <osa@FreeBSD.org> wrote: >>>> >>>> On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote: >>>>> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit : >>>>>> auth-digest is not default module, so you don't need to bump >>>>>> PORTREVISION. >>>>> >>>>> Yes you do. >>>>> To quote >>>>> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision >>>>> : >>>>> >>>>> PORTREVISION must be increased each time a change is made to the >>>>> port that changes the generated package in any way. That includes >>>>> changes that only affect a package built with non-default options. >>>> >>>> I've tried to find a commit in doc area to better understand who and why >>>> did this change. Another question is why this so important change >>>> hasn't been discussed and why committers and community haven't been >>>> notified >>>> about that in advance. >>> >>> Hi Sergey, >>> >>> It's been policy for a long time now, a number of years at least. It does >>> feel strange at first, but it really does benefit our users in the end. >>> The >>> reason we have to bump PORTREVISION for non-default options is the same >>> reason we have to bump PORTREVISION for default options. When something >>> changes, build scripts need to know to rebuild the package. There is >>> simply >>> no way for that to happen unless we tell them to. >>> >>> I know you're not a fan of forcing default option users to rebuild ports >>> when their setup hasn't changed, but the other side of it is that we >>> often >>> force non-default option users to rebuild when THEIR setup hasn't >>> changed. >>> It works both ways, and it's just a consequence of our build paradigm. It >>> has to happen though, every time. >> >> Hi Adam, >> >> thank you very much for so long answer with so many details, I think I >> understand your opinion in this case, however would you mind to provide >> a bit more details in this case (please review my questions)? >> >> Thanks in advance. >> >> -- >> Sergey A. Osokin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?825D5BD5-38D0-4F96-AEEE-2FA483F9D2BC>