Date: Sun, 10 May 2015 13:30:22 +0000 (UTC) From: Ian Lepore <ian@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r282728 - head/sys/boot/efi/loader/arch/i386 Message-ID: <201505101330.t4ADUMrm033123@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ian Date: Sun May 10 13:30:21 2015 New Revision: 282728 URL: https://svnweb.freebsd.org/changeset/base/282728 Log: Don't check the return value from self_reloc(), it can't fail and doesn't return a value. Despite what I said in my prior commit, it turns out this one platform was checking the return value from the old self-reloc code (which returned a hard-coded 0). Modified: head/sys/boot/efi/loader/arch/i386/start.S Modified: head/sys/boot/efi/loader/arch/i386/start.S ============================================================================== --- head/sys/boot/efi/loader/arch/i386/start.S Sun May 10 13:24:26 2015 (r282727) +++ head/sys/boot/efi/loader/arch/i386/start.S Sun May 10 13:30:21 2015 (r282728) @@ -54,8 +54,6 @@ ENTRY(_start) pushl %ebx /* dynamic */ pushl %eax /* ImageBase */ call self_reloc - cmpl $EFI_SUCCESS, %eax - jne 1f popl %ebx /* remove ImageBase from the stack */ popl %ebx /* remove dynamic from the stack */ call efi_main
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201505101330.t4ADUMrm033123>