Date: Tue, 04 Jan 2011 19:12:41 +0100 From: Giorgos Keramidas <keramida@freebsd.org> To: Garrett Cooper <yanegomi@gmail.com> Cc: freebsd-hackers@freebsd.org, Eitan Adler <lists@eitanadler.com>, hackers@freebsd.org, Kostik Belousov <kostikbel@gmail.com>, Alexander Best <arundel@freebsd.org> Subject: Re: [patch] have rtprio check that arguments are numeric; change atoi to strtol Message-ID: <xeiay670zgfa.fsf@kobe.laptop> In-Reply-To: <0CC6BFE3-3381-401A-A9E3-26EB7EB46A3E@gmail.com> (Garrett Cooper's message of "Tue, 4 Jan 2011 08:58:48 -0800") References: <AANLkTimiJPiHBSw5i5TVJYfh9uGOyrNJx%2BoUPeB%2Bt%2BY_@mail.gmail.com> <xeia7heluf2q.fsf@kobe.laptop> <20110104112502.GM3140@deviant.kiev.zoral.com.ua> <201101040805.59412.jhb@freebsd.org> <20110104134940.GA8529@freebsd.org> <0CC6BFE3-3381-401A-A9E3-26EB7EB46A3E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Jan 2011 08:58:48 -0800, Garrett Cooper <yanegomi@gmail.com> wrote: >>>> + errno = 0; >>>> + res = strtol(str, &endp, 10); >>>> + if (errno != 0 || endp == str || *endp != '\0') >>>> + err(1, "%s shall be a number", errname); >>> >>> Small nit, maybe use 'must' instead of 'shall'. >> >> it seems at some point there has been a massive usage of the term >> 'shall' in manual pages, which people tried to get rid of. hence the >> 'usr/share/examples/mdoc/deshallify.sh' script. > > I know shall is used widely by opengroup when describing definitions > and interfaces in the POSIX standards, but the connotation in English > is very squishy, so I agree with John that must would be better. > > BTW, only if errno was non-zero would using err(3) be > logical. Otherwise it will just produce noise :). That's a good point. I think we should change err() to errx() there.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xeiay670zgfa.fsf>