From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 4 19:50:03 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5B59686B for ; Wed, 4 Sep 2013 19:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 21A672F5C for ; Wed, 4 Sep 2013 19:50:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r84Jo2Kr045283 for ; Wed, 4 Sep 2013 19:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r84Jo2Ao045282; Wed, 4 Sep 2013 19:50:02 GMT (envelope-from gnats) Resent-Date: Wed, 4 Sep 2013 19:50:02 GMT Resent-Message-Id: <201309041950.r84Jo2Ao045282@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sven-Thorsten Dietrich Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DCB6B55D for ; Wed, 4 Sep 2013 19:40:11 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CAA332EEE for ; Wed, 4 Sep 2013 19:40:11 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r84JeBwg092883 for ; Wed, 4 Sep 2013 19:40:11 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r84JeBiN092879; Wed, 4 Sep 2013 19:40:11 GMT (envelope-from nobody) Message-Id: <201309041940.r84JeBiN092879@oldred.freebsd.org> Date: Wed, 4 Sep 2013 19:40:11 GMT From: Sven-Thorsten Dietrich To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/181823: make ipv6 mroute return same errror codes as IPv4 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2013 19:50:03 -0000 >Number: 181823 >Category: kern >Synopsis: make ipv6 mroute return same errror codes as IPv4 >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Sep 04 19:50:02 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Sven-Thorsten Dietrich >Release: HEAD >Organization: Vyatta >Environment: >Description: IPv4 mroute code returns EPERM when MRT_INIT hasn't been called. Make IPV6 behave the same way. Arguably IPv4 should return EACCESS, but since IPV6 came later, the logical first step would be to make them consistent. >How-To-Repeat: >Fix: see patch Patch attached with submission follows: IPv4 mroute code returns EPERM when MRT_INIT hasn't been called. Make IPV6 behave the same way. Arguably IPv4 should return EACCESS, but since IPV6 came later, the logical first step would be to make them consistent. Signed-off-by: Sven-Throsten Dietrich Index: netinet6/ip6_mroute.c =================================================================== --- netinet6/ip6_mroute.c (revision 255189) +++ netinet6/ip6_mroute.c (working copy) @@ -353,7 +353,7 @@ mifi_t mifi; if (so != V_ip6_mrouter && sopt->sopt_name != MRT6_INIT) - return (EACCES); + return (EPERM); switch (sopt->sopt_name) { case MRT6_INIT: >Release-Note: >Audit-Trail: >Unformatted: