From owner-svn-src-head@freebsd.org Sat Jan 26 19:11:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7232B14AAB6A; Sat, 26 Jan 2019 19:11:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 65147684C0; Sat, 26 Jan 2019 19:11:26 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f52.google.com with SMTP id t24so10393177ioi.0; Sat, 26 Jan 2019 11:11:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=PMuL/e1hexQ6CqqKdReSMYwk1EyfeYy6Nvs2tN4w/pI=; b=f7bUWKRCIO8U6x/7T6m5ux/55uQutYdbYMqDg3CyxdZLvDzRgi2bwcixAUWKfr48jR wX0h9rnitFZPfxiza22UyhVzN9fq+edwF0CBU7j6+YIsbx+5s9dulKvqaSJLy+KHpyT1 78bMY8Wmssuq6a5xICOAPkQ98vri6bL6U+beVRV5z5H1st/q7yOZxfa7BNFOQJqWyCLl 3bjTWn2trU7kUc9haQVik1qoue0PhdSbCr8epohpcu82CBOeMi97yy0+yBTDh1sBh2a5 KxDqCj8O2R5yQN1dr8rw9RWb7wlMCLuVP+R02bYq+/hHstBE2dKR1nwTYyv9Pnfq+zWG Nf8A== X-Gm-Message-State: AHQUAuaDZYVGAraMxVaECyTU54bU/UaBwcmh6haMvSLwzyVg/WHoHuvh mbJUvWR+QxGL0Q+dycn82srFK15T X-Google-Smtp-Source: AHgI3IZ25k9MpYZuYT75/ggWIGBASZcZwMNjBebWEg1DcJQ1KZwjpEA71SDz84M7ylf2cvRsfGQ7QA== X-Received: by 2002:a5d:934a:: with SMTP id i10mr9124881ioo.162.1548529880046; Sat, 26 Jan 2019 11:11:20 -0800 (PST) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com. [209.85.166.42]) by smtp.gmail.com with ESMTPSA id o192sm14823060itb.31.2019.01.26.11.11.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Jan 2019 11:11:19 -0800 (PST) Received: by mail-io1-f42.google.com with SMTP id k7so10331137iob.6; Sat, 26 Jan 2019 11:11:19 -0800 (PST) X-Received: by 2002:a6b:ee16:: with SMTP id i22mr3417581ioh.124.1548529879611; Sat, 26 Jan 2019 11:11:19 -0800 (PST) MIME-Version: 1.0 References: <201901251709.x0PH9Rc4094379@repo.freebsd.org> In-Reply-To: <201901251709.x0PH9Rc4094379@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 26 Jan 2019 11:11:08 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r343440 - head/bin/sh To: svn-src-head@freebsd.org Cc: src-committers , svn-src-all@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 65147684C0 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.52 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.55 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.84)[-0.842,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.69)[ip: (-7.76), ipnet: 209.85.128.0/17(-3.70), asn: 15169(-1.93), country: US(-0.08)]; RCVD_IN_DNSWL_NONE(0.00)[52.166.85.209.list.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2019 19:11:27 -0000 I didn't really feel the need to weigh in on this bikeshed thread previously, but apparently some folks are calling for a revert. Why? I don't really understand how this meets the high bar for summary revert, even if you disagree with the change made (and disagreement is fine, of course). So I'll raise my hand for "leave it in" and encourage talking out your bikeshed. It would be persuasive to come up with a specific list of complaints, ideally excluding ones that have been shown to be baseless. So far there has been a lot of mudslinging and it's difficult to sort out the preference complaints from the security complaints from the (well-intentioned, but ultimately inaccurate) fiction. I don't think a "heckler's veto" should be granted. If you don't use root/toor, that's fine! But I think that sort of (heavily) discounts how much weight your opinion of root/toor defaults should be given. If you use Expect, great. You should be setting a specific PS1 anyway (both before and after this change). After all, this is just the default. Users have been free to set a custom PS1 for root in .profile since time began. Has anyone verified the claim that freebsd-update will actually modify a user's home directory contents, or was that just speculation? I don't know one way or the other and I think it's still an open question. Best regards, Conrad On Fri, Jan 25, 2019 at 9:09 AM Edward Tomasz Napierala wrote: > > Author: trasz > Date: Fri Jan 25 17:09:26 2019 > New Revision: 343440 > URL: https://svnweb.freebsd.org/changeset/base/343440 > > Log: > Comment out the default sh(1) aliases for root, introduced in r343416. > The rest of this stuff is still to be discussed, but I think at this > point we have the agreement that the aliases should go. > > MFC after: 2 weeks > Sponsored by: DARPA, AFRL > > Modified: > head/bin/sh/dot.shrc > > Modified: head/bin/sh/dot.shrc > ============================================================================== > --- head/bin/sh/dot.shrc Fri Jan 25 17:08:28 2019 (r343439) > +++ head/bin/sh/dot.shrc Fri Jan 25 17:09:26 2019 (r343440) > @@ -18,13 +18,13 @@ > # set -o vi > > > -# some useful aliases > -alias h='fc -l' > -alias j=jobs > -alias m="$PAGER" > -alias ll='ls -laFo' > -alias l='ls -l' > -alias g='egrep -i' > +# # some useful aliases > +# alias h='fc -l' > +# alias j=jobs > +# alias m="$PAGER" > +# alias ll='ls -laFo' > +# alias l='ls -l' > +# alias g='egrep -i' > > # # be paranoid > # alias cp='cp -ip' >