From owner-freebsd-smp Tue Apr 25 8:29:56 2000 Delivered-To: freebsd-smp@freebsd.org Received: from lor.watermarkgroup.com (lor.watermarkgroup.com [207.202.73.33]) by hub.freebsd.org (Postfix) with ESMTP id 89EDE37BDC0 for ; Tue, 25 Apr 2000 08:29:49 -0700 (PDT) (envelope-from luoqi@watermarkgroup.com) Received: (from luoqi@localhost) by lor.watermarkgroup.com (8.10.1/8.10.1) id e3PFTgp22603; Tue, 25 Apr 2000 11:29:42 -0400 (EDT) Date: Tue, 25 Apr 2000 11:29:42 -0400 (EDT) From: Luoqi Chen Message-Id: <200004251529.e3PFTgp22603@lor.watermarkgroup.com> To: smp@csn.net Subject: Re: Multiple APIC support (RE: Issues with Spankin' new Poweredge 4400 w/ dual 866's and 133MHz FSB?) Cc: freebsd-smp@FreeBSD.ORG, mihara@prd.fc.nec.co.jp, sthaug@nethelp.no Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > > The pmap.c code looks somewhat different in 3.4-STABLE, and it wasn't > > > obvious to me what the complete patch for 3.4-STABLE would be. > > > > > The fix for non-page-aligned ioapic is to add the offset within the page > > to get the mapped ioapic address. For 3.4-STABLE, it would be > > ioapic[i] = (ioapic_t *)&SMP_ioapic[j * PAGE_SIZE > > + (io_apic_addres[0] & PAGE_MASK)]; > ^^^ > I don't have 3.4 code handy to see the outer loop, but didn't the const 0 go > away here? > > > I don't have any machine myself to test it with, so if you can confirm > > it won't break anything on your machine, I would MFC the fix to 3.4-STABLE. > > -- > Steve Passe | powered by > smp@csn.net | Symmetric MultiProcessor FreeBSD > > Sorry, the 0 should be i (cut-n-paste error). -luoqi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message