Date: Wed, 5 Sep 2012 22:21:20 +0100 From: Chris Rees <utisoft@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Florian Smeets <flo@smeets.im>, ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <CADLo83_38j6aqzG9uvhEzkpocsCSt25hthNrQf1Afo=a%2BPA45g@mail.gmail.com> In-Reply-To: <5047BF93.2060704@FreeBSD.org> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <5045E904.5080608@smeets.im> <50462DEC.3040202@FreeBSD.org> <5047B7A6.8040601@smeets.im> <5047BC0D.1000707@FreeBSD.org> <CADLo838zifx3uvTerh8h961X5r0gAC6K4LJ%2Bifnem6oXg-RPAw@mail.gmail.com> <5047BF93.2060704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 5 September 2012 22:09, Doug Barton <dougb@freebsd.org> wrote: > On 09/05/2012 14:01, Chris Rees wrote: >> >> On 5 Sep 2012 21:54, "Doug Barton" <dougb@freebsd.org >> <mailto:dougb@freebsd.org>> wrote: >>> >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA256 >>> >>> On 09/05/2012 13:35, Florian Smeets wrote: >>> > On 04.09.12 18:35, Doug Barton wrote: >>> >>> >> Portmaster, and other tools, use this method extensively to read >>> >> those files, and this issue causes those tools to break while >>> >> processing those files. >>> >> >>> > >>> > You keep repeating this, without proof. >>> >>> Um, what kind of proof do you need? I wrote the code, I know how it >>> works, and I know that the parts of it that use "while read" to >>> process distinfo files breaks because of this issue. There have also >>> been other people who have raised this issue, as relates to their tools. >>> >>> I also showed you how to reproduce it yourself. >>> >>> How much more proof do you need? >> >> I think Florian is asking for a real example, perhaps a portmaster command; >> >> % portmaster reproduce-this-error > > If Florian isn't interested in taking my word for it, he can look > through the code and find ways to reproduce it himself. :) Well, since you provoked me into it, I've had a look, the main distinfo part I've distilled into something simpler: [crees@pegasus]~% svn co $ports/head/www/xpi-firebug@r303627 A xpi-firebug/distinfo A xpi-firebug/pkg-descr A xpi-firebug/pkg-plist A xpi-firebug/Makefile Checked out revision 303627. [crees@pegasus]~% cd xpi-firebug [crees@pegasus]~/xpi-firebug% <distinfo while read s f discard ; do while> echo $s while> done SHA256 [crees@pegasus]~/xpi-firebug% Granted, that leaves off the SIZE line, but I can't see any problems here... The only part of portmaster that I can see that cares about SIZE depends on ports/106483, which is still in waiting (is this going to be needed with pkgng anyway?) Given this... specifics could be nice for people who can't distil the actual problem. I understand that this is correct, but you can't claim it affects portmaster when it actually doesn't. Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_38j6aqzG9uvhEzkpocsCSt25hthNrQf1Afo=a%2BPA45g>