From owner-cvs-all  Sat Jan 19  4:28:15 2002
Delivered-To: cvs-all@freebsd.org
Received: from obsecurity.dyndns.org (adsl-63-207-60-131.dsl.lsan03.pacbell.net [63.207.60.131])
	by hub.freebsd.org (Postfix) with ESMTP
	id D7EE037B402; Sat, 19 Jan 2002 04:28:10 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 4B3B866D7A; Sat, 19 Jan 2002 04:28:10 -0800 (PST)
Date: Sat, 19 Jan 2002 04:28:10 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: "Andrey A. Chernov" <ache@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpam/modules/pam_opie pam_opie.c
Message-ID: <20020119042808.A67985@xor.obsecurity.org>
References: <200201191009.g0JA95b91076@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO"
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200201191009.g0JA95b91076@freefall.freebsd.org>; from ache@FreeBSD.org on Sat, Jan 19, 2002 at 02:09:05AM -0800
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--2oS5YaxWCcQjTEyO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 19, 2002 at 02:09:05AM -0800, Andrey A. Chernov wrote:
> ache        2002/01/19 02:09:05 PST
>=20
>   Modified files:
>     lib/libpam/modules/pam_opie pam_opie.c=20
>   Log:
>   If user not exist in OPIE system, return failure immediately instead
>   of producing fake prompts with random numbers which can be detected by
>   potential intruder in two tries and totally confuse non-OPIE users.

Wait a minute..was this discussed anywhere?

Please don't make changes to security-critical, complex code like PAM
without a review by a competent reviewer (e.g. markm or des).

Kris

--2oS5YaxWCcQjTEyO
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE8SWZXWry0BWjoQKURAkQ7AJ4nsH3VRygXri1eHEKZVo9Ljn+UvQCgmTEq
L6cCTOPIrTULi9a3H/IC5UI=
=cyQv
-----END PGP SIGNATURE-----

--2oS5YaxWCcQjTEyO--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message