From owner-svn-ports-all@FreeBSD.ORG Tue Dec 11 13:28:45 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4E0F3E9D; Tue, 11 Dec 2012 13:28:45 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 42C098FC12; Tue, 11 Dec 2012 13:28:43 +0000 (UTC) Received: by mail-ee0-f54.google.com with SMTP id c13so2715184eek.13 for ; Tue, 11 Dec 2012 05:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jo0GfR0WB+GcmUQG8zoC74CcRP1QyYeS0V+0QCNTeV8=; b=GBTZ7UI6bWX30O7q9iPv1/KBkxm8JOeKewJC1XjQ2v52JYFP+lceg3oW/xZbpM5FZC 1WsOXekaoDx+gqAdx9XeQRcCSx232nZc8i/NJ4lY3yrfGcYgvsiiCald7rH7pBTQH12e GEBrVDrqCbDUuJ29W7dBf+sa/CrWhkDCy2rXZu1BSeC23Bx/27RaXShTiTj9t+1ALyy8 Rep+m2h9lp7f8oxvd15cMtVaKAOa1Wscf7qWpml1TUKyjZ33kxq2lFGAbeZKOzXmF6th /WnzXvk1niPZR44EVBOAqUPXxI510NdD52jezsyo4PUzbcX/u0YjLsr0ENLzZKiX/hNp VNwg== Received: by 10.14.184.131 with SMTP id s3mr60272981eem.38.1355232523062; Tue, 11 Dec 2012 05:28:43 -0800 (PST) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPS id r1sm49850715eeo.2.2012.12.11.05.28.42 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Dec 2012 05:28:42 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 11 Dec 2012 14:28:41 +0100 From: Baptiste Daroussin To: Dmitry Marakasov Subject: Re: svn commit: r308655 - in head/games/xmoto: . files Message-ID: <20121211132840.GD58883@ithaqua.etoilebsd.net> References: <201212110314.qBB3EErH082058@svn.freebsd.org> <20121211033625.GA39028@FreeBSD.org> <20121211132128.GA50148@hades.panopticon> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sgneBHv3152wZ8jf" Content-Disposition: inline In-Reply-To: <20121211132128.GA50148@hades.panopticon> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2012 13:28:45 -0000 --sgneBHv3152wZ8jf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 11, 2012 at 05:21:28PM +0400, Dmitry Marakasov wrote: > * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: > > On Tue, Dec 11, 2012 at 03:14:14AM +0000, Dmitry Marakasov wrote: > > > New Revision: 308655 > > > URL: http://svnweb.freebsd.org/changeset/ports/308655 > > >=20 > > > +OPTIONS_DEFINE=3D ASIAN_TTF > > > =20 > > > [...] > > > =20 > > > +.if ${PORT_OPTIONS:MNLS} > > > [...] > > > +.if ${PORT_OPTIONS:MDOCS} > >=20 > > Looks like these two should also be mentioned in OPTIONS_DEFINE. >=20 > Not adding them to OPTIONS_DEFINE preserves previous behaviour and I > don't think NLS and DOCS should be in the OPTIONS_DEFINE ever - they are > only meaningful to be set globally, and having them in individual ports > makes large builds much more painful, as a user has to set them for tons > of ports (even more painful without portmaster or knowing of > config-recursive). My opinion on this is if you have already an OPTIONS_DEFINE it means that t= he dialog(1) will be shown anyway so it doesn't hurt to add NLS and DOCS to it. if you do not have OPTIONS_DEFINE for something else then yes I can underst= and you don't want to bother users with dialog coming up all the time. regards, Bapt --sgneBHv3152wZ8jf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDHNQgACgkQ8kTtMUmk6EyJXgCfcf3eYON14MVlli8OwfmYUMvT yZkAn2hjNnwNmXYzfgy83/oXzjG/q05W =MH85 -----END PGP SIGNATURE----- --sgneBHv3152wZ8jf--