From owner-cvs-src@FreeBSD.ORG Mon May 15 08:51:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10E6016A53B; Mon, 15 May 2006 08:51:36 +0000 (UTC) (envelope-from bms@spc.org) Received: from mindfull.spc.org (mindfull.spc.org [83.167.185.3]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51A2143D66; Mon, 15 May 2006 08:51:35 +0000 (GMT) (envelope-from bms@spc.org) Received: from arginine.spc.org ([83.167.185.2]) by mindfull.spc.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.52) id 1FfYna-0007Yc-5K; Mon, 15 May 2006 09:51:31 +0100 Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 3C11065499; Mon, 15 May 2006 09:51:32 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 24249-02; Mon, 15 May 2006 09:51:31 +0100 (BST) Received: by arginine.spc.org (Postfix, from userid 1078) id 1AA59653F9; Mon, 15 May 2006 09:51:31 +0100 (BST) Date: Mon, 15 May 2006 09:51:31 +0100 From: Bruce M Simpson To: Bruce M Simpson Message-ID: <20060515085131.GG46921@spc.org> Mail-Followup-To: Bruce M Simpson , Bruce M Simpson , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, pavlin@icir.org, atanu@icir.org, rwatson@FreeBSD.org References: <200605141422.k4EEMnmC056704@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605141422.k4EEMnmC056704@repoman.freebsd.org> User-Agent: Mutt/1.4.1i Organization: Incunabulum X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - mindfull.spc.org X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - spc.org X-Source: X-Source-Args: X-Source-Dir: Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, rwatson@FreeBSD.org, pavlin@icir.org, atanu@icir.org Subject: Re: cvs commit: src/sys/netinet in.h ip_output.c ip_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 May 2006 08:51:39 -0000 [Cc: to Pavlin] On Sun, May 14, 2006 at 02:22:49PM +0000, Bruce M Simpson wrote: > By making the imo_membership array a dynamically allocated vector, > this minimizes disruption to existing IPv4 multicast code. This > change breaks the ABI for the kernel module ip_mroute.ko, and may > cause a small amount of churn for folks working on the IGMPv3 merge. I've just realized this change is incomplete with respect to options MROUTING, when reviewing it for impact on the ABI. What needs to be done in ip_mroute.c is for a temporary vector to be spoofed up in tbf_send_packet() before it enters ip_output(), when vif tunneling is not in use, and which then needs to be freed once ip_output() is done, as the ip_moptions struct there is allocated on the stack. I believe this is the right fix but would appreciate feedback from folks who know the MROUTING code. Given the low number of dynamic consumers (ip_mroute and if_carp, besides netinet itself) I would be inclined to MFC this to RELENG_6 if people are happy with the change overall and the fact that this breaks the ABI for those modules, though I wouldn't plan to do this for another 2 weeks. Regards, BMS