From owner-freebsd-tinderbox@FreeBSD.ORG  Thu May  5 15:54:45 2005
Return-Path: <owner-freebsd-tinderbox@FreeBSD.ORG>
Delivered-To: freebsd-tinderbox@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 618)
	id 42D4E16A4CF; Thu,  5 May 2005 15:54:45 +0000 (GMT)
In-Reply-To: <20050505204235.L7880@delplex.bde.org> from Bruce Evans at "May
	5, 2005 08:52:39 pm"
To: bde@zeta.org.au (Bruce Evans)
Date: Thu, 5 May 2005 15:54:45 +0000 (GMT)
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20050505155445.42D4E16A4CF@hub.freebsd.org>
From: wpaul@FreeBSD.ORG (Bill Paul)
cc: amd64@FreeBSD.org
cc: current@FreeBSD.org
cc: tinderbox@FreeBSD.org
cc: delphij@frontfree.net
Subject: Re: [current tinderbox] failure on amd64/amd64
X-BeenThere: freebsd-tinderbox@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Tinderbox reports, responses, and meta-comments
	<freebsd-tinderbox.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-tinderbox>,
	<mailto:freebsd-tinderbox-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-tinderbox>
List-Post: <mailto:freebsd-tinderbox@freebsd.org>
List-Help: <mailto:freebsd-tinderbox-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-tinderbox>,
	<mailto:freebsd-tinderbox-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 May 2005 15:54:45 -0000

> On Thu, 5 May 2005, Xin LI wrote:
> 
> > On Thu, May 05, 2005 at 04:44:28AM -0400, FreeBSD Tinderbox wrote:
> >> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c: In function `NdisMFreeSharedMemory':
> >> /tinderbox/CURRENT/amd64/amd64/src/sys/modules/ndis/../../compat/ndis/subr_ndis.c:1710: warning: long long unsigned int format, uint64_t arg (arg 3)
> >
> > Maybe we should make use of the PRIx64 macro?  (see patch attached)
> 
> No.  PRI* is a bug in C99; it should never be used.  Just cast the arg to
> a suitable larger type with a known format (uintmax_t here).  (C99 is
> missing support for better ways; either %I as in sfio (?) or %DWIM where
> the compiler rewrites the string to match the arg would be better.)
> 
> Bruce

I think what you really meant to say was:

"Use %jx instead of %qx."

Am I right?

-Bill

--
=============================================================================
-Bill Paul            (510) 749-2329 | Senior Engineer, Master of Unix-Fu
                 wpaul@windriver.com | Wind River Systems
=============================================================================
              <adamw> you're just BEGGING to face the moose
=============================================================================