From nobody Thu Nov 16 16:47:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SWQtn5Gh7z50rBF for ; Thu, 16 Nov 2023 16:47:29 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SWQtn3gyNz3H8f for ; Thu, 16 Nov 2023 16:47:29 +0000 (UTC) (envelope-from matthew@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700153249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GE5DLn+Q9dcgREL+UWDIHDcdAr2A2jaHUUmTrqQhhNw=; b=v7U8qobDBdD97z6vhd2Hri9I20TX7e/w8tmgAq+EP+8acZDJZzUUDDBio5R4mNbhKODFDo qpxDGamDfjn2r2a7ATFjdsK926tvkGxWKMS1C4wslaJ91PcnnlC9fIm0Fw2W/hLImH0EDg ckErRpXFd0XgWXReNCl5kXrBdp/npGVTbrUaFUdr8roHAAIJMhSS/j49i4TCMjLk4LFqka PBNkB7nci/s5liP25KYm6+76k89mT2WrS85ggsEphuq2bNziGLn3wntKudzmJa8vtTFTyj vyrIh8eI0/u/GSbGE/BgaaPXXWSrvXrJetkaX9uf5rA2WiNkGEM9VLahufztIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700153249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GE5DLn+Q9dcgREL+UWDIHDcdAr2A2jaHUUmTrqQhhNw=; b=jNmQrbnBztxGSG2P49XaXLAINJay5pwmMvJ29333/tRnKxCrdpPhhpGk5ci0lfNts6SE5Y MdYZxMvzw95k1UI8NWfvblHzrW5yVqddy8SkH678stDVb7lw1yvZeWOYeXyDkoblHsdj9Y T8/paQDOyMjP3wa8CJdMqBJ2ChQlAlHd23nT5N0EdgJqBdEb2htiiduCjbSnLTP0wrpcFs tySj5pWhuJg3dC6j3QTubAGuNkQZ6MFCAZLbSwArN5oI1aPm8hIPkDeaumUmpUC55zN6Ac VD58EPT7QxQ3SJ2ty+dR6LFcxwtFoA/zA1BNfN73Uxl90pSnFXE7U1TMnKWI2w== ARC-Authentication-Results: i=1; smtp.infracaninophile.co.uk; dmarc=none (p=none dis=none) header.from=FreeBSD.org ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700153249; a=rsa-sha256; cv=none; b=VvyVPTM2zSmCyXUyIDByJFwEAGNggsDUpFOQGNF4U8z1DDUWto4LoL9R+KijMKxCFyDQog 9NFhsadDV/0dDLImp5HzchQszkh6zOj+rszHrxR7NQB8+Cv2YXdTHQYi837tKrqh0mLhrN i7Kk/sochHZhpSpJs1lhM2KT8EjyAow6nNzNGpMhARCSUQU2y+6qiiUHNPKBdi08mE6/Sa XggPZf0rWF7ZncolvqcVnYU3N+ElZ1JG+iiqv9Czc0klnlLrx/k0QxCo5qGGmbfOeZu9t2 7B+NphRiutOXoW95ArDZT/FIwpgN5aqtkxEARhQgqBKn1xD8QIsaoh0DQWRY7A== Received: from smtp.infracaninophile.co.uk (smtp.infracaninophile.co.uk [IPv6:2001:8b0:151:1:c4ea:bd49:619b:6cb3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: matthew/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SWQtn0lTgz12Nc for ; Thu, 16 Nov 2023 16:47:29 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from [IPV6:2001:8b0:151:1:d14b:641e:6160:9c16] (unknown [IPv6:2001:8b0:151:1:d14b:641e:6160:9c16]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) (Authenticated sender: m.seaman@infracaninophile.co.uk) by smtp.infracaninophile.co.uk (Postfix) with ESMTPSA id 383B31E11F for ; Thu, 16 Nov 2023 16:47:23 +0000 (GMT) Authentication-Results: smtp.infracaninophile.co.uk; dmarc=none (p=none dis=none) header.from=FreeBSD.org Message-ID: <514d9136-e169-47a2-9279-d9ef56697e9e@FreeBSD.org> Date: Thu, 16 Nov 2023 16:47:22 +0000 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: accfb4cc9346 - main - genoffset.sh: stop using a temporary file To: dev-commits-src-all@freebsd.org References: <202311161507.3AGF7kgx070201@gitrepo.freebsd.org> <39921E4A-4C15-4D8F-BA9F-D0C53AD62CD1@freebsd.org> Content-Language: en-GB From: Matthew Seaman Autocrypt: addr=m.seaman@infracaninophile.co.uk; keydata= xsFNBFJIL80BEADi7/VbnnErDU6pjEhI/SzEZ/HbDRkJ5g7HroAtqIRm6nj8ZwOAgZ/2ZnWn 5F+fXTuLsG0FLNtkd17FoVcuCi5e/GPliXI5cmamV7E1Yz4T8UsJ7RQolimyxVexccKd16Tc AA7B9bFlJSKkBUSD0buj7VjT07xWhRzu6Vgi5r0UjLALYJz977uZA0F1aOGOXREDEAOhdcNc kSNjynqAwDA6dCT1Elpi4key1fYjv4jyDF+GU/YXul2Y/rguA8FCkHd9vyym5eAsLQ5mG00V V9fkEHIpH5KorNVnl/ufHXnkZqmHAZVpFDcrshb7aZ/pL45PXyWgLj+e6etelgj3a2bZi0JF cVdXCnBZVP2oIyYblM11ugTbfCwodORU8a5KfPeztMdAtDr4e+32NTrPdPi5rLT+GUsYz+PL 3A3m3u8bdsFp40DlIrBtSByVjqERxcfhphrEB4J8BXHUG7OAtXkZMlW/PGKDwXJq0O6Z5Tcg YHAoEiSWbXiexHgXNJyP+sqnIlhLWhSJGeJ+C83wqI6oYlZUCW00NkPxcIHnQPV/z+5wQVci TMyaWC2YCIHz4Ljs+TnwWMz0E8PNFDfHVbQ0W4PRGV7gRAqxfL+yKufauIEGbEq8rNDbSwL3 bcUCxR4ZDlaUEUwT4J8naf7rjdgiEYHs2Ig3jeK1+ER4FPG1sQARAQABzTBNYXR0aGV3IFNl YW1hbiA8bS5zZWFtYW5AaW5mcmFjYW5pbm9waGlsZS5jby51az7CwZcEEwEKAEECGwMFCwkI BwMFFQoJCAsFFgIDAQACHgECF4ACGQEWIQRyz6whebywJLW1RZADb2ye5/OevwUCZEZBFAUJ E99ExwAKCRADb2ye5/Oev/3gD/94LcABf5vo1cmkObEPvPow5qn/MvhIo2E5LKBbFX4I3xd5 H436rSRvaRcyVXLBlz3salqsPeIHHfB1QDpMHJo6uMLunkiEg4JSLWk9mSFh/YxgdIjjOpjE xndpLwJo/dphwVD6ZSDz6iWN1hf2cDWVPBR+c7LaGmYIHY6sMHkFj7TA3SgnYpWA5yjUtQqs +sETL9MD5IKgbmcICQtonmK6PydyLosTDKNcTAxZvaMZ2Oj1OfHxUQBSeUtDuLPP/MUwYPwu wamlVVYosdGQg8IIPVNkloDYYgGgXxGuq1x7qe0f2grHqQdjFWs/7+xnju1yHNIrtOv7LC+8 qABvkjcjnOWgVQFUj/390MGULNf86g7MMUw1xh5RxwGCeZS1oP8WBjEFFTTRtkX/EC1LZ/qJ 35dfaYVcRMhrSo1GTL3fNfhOSMYyrMQfSMPRMgCsJo+5/f6TCXgYpiZ3bfKzxpylkr10zAoX /v7ZqLpaEVLm0rpYyKByL3hTt3WgoeS/PlI2HXZX+f+0XivBoeEr3RqVcxGd2V+fab5JDMeI 9Gcuj0lF7MWT5ffXpezkbsif7DruB3ULD5cyvg5upxYD3lzkL4vBCltMH1sBwV104zr/65KQ pxlNlJbMVP2KnqO01sRhGoOa7F8oKflFrxD610Sbn4Ib/r396gFoswv8fE3clc7BTQRSUUK4 ARAA1FhWoOejtwmsnGshoIbda2FmM+z/f97OzpagLhACHfP5Es/I18wG/0G+rdNuO2tjA9IM Z44GUMtjokDrDk63N9S+rVKy1QEy+UN6CiIfYTpTTAPnEY7IGN1JjGksPhn7aeuBCQwUMAV1 k+wklBCcOD6s8DD4kx0ZJqkH83XzWoBSVamdHvnM56C8yPVr5HHMC1tZInAWBMrF+cjl1EPf z3CqkVnG8Sxc5ydeibMS9Q3lHLeVkVlMRAmNqzNLfgJDUWtzac7JIjFEsxYYhpiaPcsstUUu Ha4zIRJ/yHDNbDttWRf1lrlFZLpeuap4BZ2hQw0UOZVNwGoFoS4ZqaZiv8mm0lX6s9/AdQD6 AVrpXWKa7JU2wDiay9sRbYh+5vVWGz9mhncK/Vfwtu5IjVp5v5WMz/WfnUxZMcNlfgTo4i1s www+qRBO2A4Yj8qKKWnTsl7aCX92itTiPgwbt6YgQPwgww72r67jPt5o8VMXDqPMPKzGicw1 AyxtMjsoSlnn91FuZctwil3vPpvzGXtBmrzQSbdDmy0KT5p5/W9pD/8UtLLLM6PLs5X0jIho vQHnQKEUO7xV3yNDAW9DPICeh7f/o9W+QJfQAXngNz0brvmgScAUXRaeAFeQbAmtEG92qlSV D7gb7WOemllgfbEn0Nanrv5aEcZCWx4WjybMLHEAEQEAAcLBfAQYAQoAJgIbDBYhBHLPrCF5 vLAktbVFkANvbJ7n856/BQJkRkFyBQkT1jI6AAoJEANvbJ7n856/r6AQANucYy3bVJ0obU75 5AXMVIMj1nRA6LU9u+lAnYb+wMSVHXkNrW8GssqmiUGL0hJ0HNRXJLeI85YMhvXTmVYk0JqF LRp0Kj3aMbtaouCIbYTn2aaczwGViu3aQmgQe2ki+KrzxwYyG8FkHRp43+FTuBeYs6wbA36F g3eCp+Icx6X9evEeOajrgsaDr2badP9nHCYb/If1E57VC0pgx2R2/eBAtN5dlCWfgg5wJ0cI JUg3TJT4GPnumk7kLUN7U3ORQSQldiSvOBi6gpY0i8UCbmG6R5qs363J1cY7ry/enjg7GVA8 glu2Z+EHcZrEFAhvpmI+pkoyKCR0/KCv+s0rqQ5t606uquS15sr8NW2YejbeOOaEvNscKx8L QAFMaPxS/6DX+BsFAFXVWLwW/9wdaETDURf7i0EnT4xklmyyWeYMEF7mZ1x5OXdV/hAE1SFS nyuqs2SAYnpa81QQ4Eo1yehyntgdHSaOdSz3Fw7dFIiAXHvwBYf6rvTwF2MG6v3iQ+dgRv1N r+okN0LLmBjh1aYS43fvPXbwB0aBzVJZYO+a5AkPkabvblLaA1pl+V+BMUpAQhuxrDM7wsf0 6i8RpF5MjrZr12DsU2moFR2oYOmwtWBt+yI8zuYbbZ1uLR5bmyU7QquRPmQHPHrHp6mHCJfu zOyJzcEbUOrc6WHFOLbe In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/11/2023 16:23, Warner Losh wrote: > On Thu, Nov 16, 2023 at 9:07 AM Jessica Clarke wrote: > >> On 16 Nov 2023, at 15:07, Jonathan T. Looney wrote: >>> printf '\t"struct "#s"_lite field "#f" not at offset "#o)\n' >>> - cat "$temp/asserts" >>> + echo -e "${asserts}\c" >> >> This isn’t POSIX, and isn’t supported by macOS’s sh, so breaks the >> build there. Please fix or revert promptly. >> > > echo "${asserts}" > > is semantically the same for C. A stray newline doesn't matter in this > context. It's not worth the effort to remove it. > > Sadly, echo -n doesn't work (it's not posix, and posix defines it > specifically as implementation defined). `echo "fred\c"' works on macos, > but not FreeBSD's shell echo built-in (but somehow does for /bin/echo). > macos doesn't implement -e at all (it's also not posix). FreeBSD's shell > echo build-in is not posix compliant. So, to be portable, just echo it, and > cope with the extra newline. > > That's what I'd do :) > Why not just use printf(1) like in the preceeding line of code? printf "%s" "${asserts}" will avoid adding any extra newline characters to the output. Matthew