From owner-cvs-all@FreeBSD.ORG Wed Jul 23 15:04:22 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7174537B401; Wed, 23 Jul 2003 15:04:22 -0700 (PDT) Received: from pool-151-200-10-97.res.east.verizon.net (pool-141-156-222-108.res.east.verizon.net [141.156.222.108]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53ACE43F93; Wed, 23 Jul 2003 15:04:21 -0700 (PDT) (envelope-from mtm@identd.net) Received: from kokeb.ambesa.net (3o77zfd3uqo26ycy@localhost [127.0.0.1]) id h6NM4K49062911; Wed, 23 Jul 2003 18:04:20 -0400 (EDT) (envelope-from mtm@identd.net) Received: (from mtm@localhost) by kokeb.ambesa.net (8.12.9/8.12.9/Submit) id h6NM4JtC062910; Wed, 23 Jul 2003 18:04:19 -0400 (EDT) (envelope-from mtm@identd.net) X-Authentication-Warning: kokeb.ambesa.net: mtm set sender to mtm@identd.net using -f Date: Wed, 23 Jul 2003 18:04:19 -0400 From: Mike Makonnen To: Peter Wemm Message-ID: <20030723220418.GA62833@kokeb.ambesa.net> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200307232029.h6NKTDHP031126@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/5.1-CURRENT (i386) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:04:22 -0000 On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote: > peter 2003/07/23 13:29:13 PDT > > FreeBSD src repository > > Modified files: > sys/kern kern_umtx.c > Log: > Initialize 'blocked' to NULL. I think this was a real problem, but I > am not sure about that. The lack of -Werror and the inline noise hid > this for a while. No, I don't think it was a problem. It does get initialized before use in the same if.. statement it is compared in: uq = umtx_lookup(td, umtx); if (uq == NULL || (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ It might be against style, though. Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | D228 1A6F C64E 120A A1C9 A3AA DAE1 E2AF DBCC 68B9 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon!