From owner-svn-src-head@freebsd.org Sat Apr 15 07:12:47 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18BEED3FF1C; Sat, 15 Apr 2017 07:12:47 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-pf0-x22a.google.com (mail-pf0-x22a.google.com [IPv6:2607:f8b0:400e:c00::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB5E2B54; Sat, 15 Apr 2017 07:12:46 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by mail-pf0-x22a.google.com with SMTP id s16so48154878pfs.0; Sat, 15 Apr 2017 00:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=oZZv8PFhZ9HAk7iLSf5uS9UsFwa4APOBnVnrMmTJXYs=; b=Z9jDK+2vs75B94SmrBZCyLgDLT4mWNVMQvSlfuis6liae7znW2wJ0RfdKrGMpQIGiP dHkXWMfBcRAcA7lsHpf/ZKoWUmkoJrZ5ocXlebXdkTleBidLR41opQb/4IZOT6sN3LAy 1d9Cgxier7HfLeWa1AFcca6Z1O9VRdRNpy000GQAu3MaCfij4UQIrDmJmlBtVeNxAH1w 1kgbx2aXwQMRevk/2hgQ9NqdyYF/8iMUVXF1LBvmk8hyqAOkY/1EiPlw+jA+2hojt4Vn zGdB/Xi1f+aB3rYahT2IkZSAzVaLks/pVAyzlQRIcv4h4WjQB8TJISxwJpB87IRL5VJS B4ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=oZZv8PFhZ9HAk7iLSf5uS9UsFwa4APOBnVnrMmTJXYs=; b=TW9WGeNTH1kZBCMOo2lfpw/MaL29hsu3Ay+BRayOF//H+q1VEq12iVRX6bCFoHZozX DOqnD0hAJKcgCxQmbLyQA4HWHF/4UlKojB5g+0Uu2qWw0SRuQmHbYO2GJfMhZQUyXLPd UC1G6CrrqCHWdOiuI4euOP4TJky4Pw2KKN4QZSZlJmwtqnLdQ1KJqMLpIyaKfwCYt89h +QAbsCaiKMPYo5wpYT+05zBBUd39qn7vRq0l7jlVReEPuoHSSs9GXTMvZ/Y8HepWAQKn 8hB/3slibTmEmjqqtCA8M0RIhmEKh4rx7X+dfT6EfrzU5sP1xAzD2ER22E3CmkekmNVa a4bQ== X-Gm-Message-State: AN3rC/4Fh9orriDO7fO53NDlwpv3TVM3mZh8AashYbZTxoquZYTlyQ17 KqiwH6bopJdI+qEs X-Received: by 10.98.44.142 with SMTP id s136mr1429244pfs.244.1492240366384; Sat, 15 Apr 2017 00:12:46 -0700 (PDT) Received: from ox ([2601:641:c000:b800:201d:8cb6:8467:a85c]) by smtp.gmail.com with ESMTPSA id p80sm6676691pfk.50.2017.04.15.00.12.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Apr 2017 00:12:45 -0700 (PDT) Sender: Navdeep Parhar Date: Sat, 15 Apr 2017 00:12:33 -0700 From: Navdeep Parhar To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316936 - head/sys/dev/cxgbe/iw_cxgbe Message-ID: <20170415071233.GA12250@ox> Mail-Followup-To: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201704141915.v3EJFVMX093441@repo.freebsd.org> <201704150115.v3F1FAbU009132@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704150115.v3F1FAbU009132@pdx.rh.CN85.dnsmgr.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 07:12:47 -0000 On Fri, Apr 14, 2017 at 06:15:10PM -0700, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] > > Author: np > > Date: Fri Apr 14 19:15:31 2017 > > New Revision: 316936 > > URL: https://svnweb.freebsd.org/changeset/base/316936 > > > > Log: > > cxgbe/iw_cxgbe: hw supports 64K (not 32K) Protection Domains. > > > > MFC after: 3 days > > Sponsored by: Chelsio Communications > > > > Modified: > > head/sys/dev/cxgbe/iw_cxgbe/t4.h > > > > Modified: head/sys/dev/cxgbe/iw_cxgbe/t4.h > > ============================================================================== > > --- head/sys/dev/cxgbe/iw_cxgbe/t4.h Fri Apr 14 18:56:00 2017 (r316935) > > +++ head/sys/dev/cxgbe/iw_cxgbe/t4.h Fri Apr 14 19:15:31 2017 (r316936) > > @@ -61,7 +61,7 @@ > > > > #define T4_MAX_NUM_QP (1<<16) > > #define T4_MAX_NUM_CQ (1<<15) > > -#define T4_MAX_NUM_PD (1<<15) > > +#define T4_MAX_NUM_PD 65536 > > Why the change in methods of expressing powers of 2 here? > This, imho, would better match the near by code as > #define T4_MAX_NUM_PD (1<<16) > r316940 removed both of the 1<