From owner-svn-src-head@freebsd.org  Mon Jun 26 14:32:16 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00BABD88C5C
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Mon, 26 Jun 2017 14:32:16 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org
 [54.200.247.200])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D9B187B8F2
 for <svn-src-head@freebsd.org>; Mon, 26 Jun 2017 14:32:15 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 3ed2f43a-5a7c-11e7-8dc9-a95799a96e8f
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound1.ore.mailhop.org (Halon) with ESMTPSA
 id 3ed2f43a-5a7c-11e7-8dc9-a95799a96e8f;
 Mon, 26 Jun 2017 14:32:14 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id v5QEW7X3017552;
 Mon, 26 Jun 2017 08:32:07 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1498487527.85102.5.camel@freebsd.org>
Subject: Re: svn commit: r320360 - head/usr.bin/resizewin
From: Ian Lepore <ian@freebsd.org>
To: Edward Tomasz Napierala <trasz@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Mon, 26 Jun 2017 08:32:07 -0600
In-Reply-To: <201706261314.v5QDEfHj014897@repo.freebsd.org>
References: <201706261314.v5QDEfHj014897@repo.freebsd.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2017 14:32:16 -0000

On Mon, 2017-06-26 at 13:14 +0000, Edward Tomasz Napierala wrote:
> Author: trasz
> Date: Mon Jun 26 13:14:41 2017
> New Revision: 320360
> URL: https://svnweb.freebsd.org/changeset/base/320360
> 
> Log:
>   Make resizewin(1) do flushing by using TCSAFLUSH instead of TCSANOW
>   followed by tcflush(3).  This works just as well and is more
> elegant.
>   
>   Suggested by:	bde
>   MFC after:	2 weeks
>   Sponsored by:	DARPA, AFRL
> 
> Modified:
>   head/usr.bin/resizewin/resizewin.c
> 
> Modified: head/usr.bin/resizewin/resizewin.c
> =====================================================================
> =========
> --- head/usr.bin/resizewin/resizewin.c	Mon Jun 26 13:11:21
> 2017	(r320359)
> +++ head/usr.bin/resizewin/resizewin.c	Mon Jun 26 13:14:41
> 2017	(r320360)
> @@ -91,20 +91,15 @@ main(int argc, char **argv)
>  			exit(0);
>  	}
>  
> -	/* Disable echo */
> +	/* Disable echo, drain the input, and flush the output */

This comment is backwards.  Draining happens to output, and flushing
happens to input.

-- Ian