From nobody Sat Sep 27 15:14:00 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cYrZc6YM5z68DFK; Sat, 27 Sep 2025 15:14:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cYrZc4LCmz44KK; Sat, 27 Sep 2025 15:14:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758986040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PB3zAaCfh21GsHuSfWTF395WiyH2iJyrbUkEnh76aIg=; b=oWjAxang4As2VzXFwfD5r2g4KFfeHJjyYml3TiywdwboU45bc9hytygxE6uxiWibCRKxhg IOKfgQ9DAZVkNSolni1OvANi6LMmOB0aE3KRKgCIWL/0Sg7PbHgwgDhwE0YSAPh7lxvSCd YO6No9e9Sv9BywrxMQgL2usEhPcCttEGsnuELTdqEn6nqmcd61rmfmq6cSbI7ovFoPQzV/ YWoZK73fM4miWU5RLeeiWxchKk7SQiVP6SJ1V5Y6F0buUv59cUNwSsFqSmWgn0HKD86NlD dL7DY89QeKBXFf083ShY2056knEyEVTzm6sf9CYxmSksdV9wZfiXrt2QDI6yFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758986040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PB3zAaCfh21GsHuSfWTF395WiyH2iJyrbUkEnh76aIg=; b=Fa972DfIUEXfRKirZyqxIrL2NDkgfuRti7ARQhJOt10xf9P10WclqvYisSWSHgK6HwGBeb gXWF6Tp2eHhjYshQ8ijbA5iZfUmPVylqIB9FbrMqNUFNrefucv58Wq0i46yj7cym3+PMvQ dl5id7vT8x0AIlewz1g93VT+W6A2zOacGzvS9pcjlqvEf3OET+NojdQpeitucru07kVtt/ GF3Qsi8bt1fr8aLZcfrldKr8p9pRTlNniURTiGwMWOiE7wRf/ogKKs166lRzUflCy1xFWr Q5zcWHEM6A+BbDVkCOA0dRgyMvgydjHUygarGJ/FLe90OMVpmvnXkYFJoRoiDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758986040; a=rsa-sha256; cv=none; b=DVv05lfL8je415jaoMvrIg5MvypXvEgoTDpEiKSYSQ7wifh2mS2/vdjc6DtOULthC0UVLz UwYS79Adct4p8I07MsAAezf4UQ3srWqGIdRe1dV1mrEgBB/0l5NHL9bLkCruNRPwEj13Bh WE7h6pRu0goVMzH7XOZdGkWEtb7/Cab659Sl4brdoEghMBNaD4asEnXnE/lkmcQNn5NLIA RB1fuWcHdcyWgyV252sciIcrpDkAU1ddluDjHUe1a4F5pyVaYs9UxI4tuEeUWZEbbNUa4F UQSVxOFPmiWpRzz5Q39axbmYXjOXxybIL2CkLp0/4zeC8ccpWIyzNbu8IHWjbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cYrZc3t4nzg51; Sat, 27 Sep 2025 15:14:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58RFE0mX083243; Sat, 27 Sep 2025 15:14:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58RFE0GR083240; Sat, 27 Sep 2025 15:14:00 GMT (envelope-from git) Date: Sat, 27 Sep 2025 15:14:00 GMT Message-Id: <202509271514.58RFE0GR083240@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: e05d4c4c08b2 - stable/14 - ethernet: Prefer memcmp() over bcmp() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e05d4c4c08b2d515713e909cb9c5a30a7c9da153 Auto-Submitted: auto-generated The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=e05d4c4c08b2d515713e909cb9c5a30a7c9da153 commit e05d4c4c08b2d515713e909cb9c5a30a7c9da153 Author: Zhenlei Huang AuthorDate: 2025-09-03 17:09:11 +0000 Commit: Zhenlei Huang CommitDate: 2025-09-27 15:11:36 +0000 ethernet: Prefer memcmp() over bcmp() The link-level address and the mbuf shall not overlap. Prefer memcmp() over bcmp() for slight performance gain. No functional change intended. Reviewed by: glebius MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D52345 (cherry picked from commit 51098f0529f0d1cc532512e0eae9bfcffb8e68e4) --- sys/net/if_ethersubr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/if_ethersubr.c b/sys/net/if_ethersubr.c index b0e459dd1bdf..d33d8f682521 100644 --- a/sys/net/if_ethersubr.c +++ b/sys/net/if_ethersubr.c @@ -712,7 +712,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) * seen by upper protocol layers. */ if (!ETHER_IS_MULTICAST(eh->ether_dhost) && - bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) + memcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) m->m_flags |= M_PROMISC; }