From owner-cvs-usrbin  Fri Aug  4 18:21:52 1995
Return-Path: cvs-usrbin-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.11/8.6.6) id SAA18723
          for cvs-usrbin-outgoing; Fri, 4 Aug 1995 18:21:52 -0700
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34])
          by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id SAA18705
          ; Fri, 4 Aug 1995 18:21:27 -0700
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id LAA26907; Sat, 5 Aug 1995 11:16:38 +1000
Date: Sat, 5 Aug 1995 11:16:38 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199508050116.LAA26907@godzilla.zeta.org.au>
To: joerg@freefall.cdrom.com, rgrimes@gndrsh.aac.dev.com
Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c
Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com
Sender: cvs-usrbin-owner@freebsd.org
Precedence: bulk

>>   Modified:    usr.bin/xinstall  xinstall.c
>>   Log:
>>   Make install not remove the target file if -s has been specified but
>>   stripping failed (since the file has been a shell script, for
>>   example).

>Ignoring error conditions from strip is not a good idea.  Using -s option
>to install non binary files is a usage error.  

I thought the patch in the PR was so obviously wrong that it wouldn't be
applied.

>Removing the file if strip failed is probably not the right thing to

`install' has already unlinked the original file so there's nothing better
to do than to remove the results of the usage error.

>do, but being silent about strip errors is not a good idea.

Yes.

Bruce