From owner-svn-ports-all@freebsd.org Wed Aug 22 02:53:19 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19B031089087; Wed, 22 Aug 2018 02:53:19 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AA31C7C848; Wed, 22 Aug 2018 02:53:18 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-174-109-174-192.nc.res.rr.com [174.109.174.192]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id w7M2r6C4020854 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Wed, 22 Aug 2018 02:53:12 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r477673 - head/devel/guile-lib To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201808202103.w7KL392E026427@repo.freebsd.org> <20180821055033.GB50546@FreeBSD.org> From: Steve Wills Message-ID: Date: Tue, 21 Aug 2018 22:53:01 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180821055033.GB50546@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [199.48.129.64]); Wed, 22 Aug 2018 02:53:13 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 02:53:19 -0000 Hi, On 8/21/18 1:50 AM, Alexey Dokuchaev wrote: > On Mon, Aug 20, 2018 at 09:03:09PM +0000, Steve Wills wrote: >> New Revision: 477673 >> URL: https://svnweb.freebsd.org/changeset/ports/477673 >> >> Log: >> devel/guile-lib: Update to 0.2.6.1 >> >> While here, assign maintainer > > There're more changes to this port that were not properly documented. > >> -PORTVERSION= 0.2.2 >> +PORTVERSION= 0.2.6.1 > > So it look like a relatively minor update... > These pages, down to 2013-01-31, show the list of changes back to the previous verion: http://git.savannah.nongnu.org/cgit/guile-lib.git/log/ http://git.savannah.nongnu.org/cgit/guile-lib.git/log/?ofs=50 There are quite a few changes there and especially many of them related to building. So this doesn't look like what I'd call "a relatively minor update", except in terms of the version numbering. >> -BUILD_DEPENDS= guile:lang/guile >> -RUN_DEPENDS= guile:lang/guile > > But 0.2.2 required lang/guile, why 0.2.6.1 had switched to lang/guile2? > See: http://git.savannah.nongnu.org/cgit/guile-lib.git/commit/?id=c62196b3201f365b938a2f88a1c2822947abd789 So either version should be fine, I think we want to use the latest version whenever we can, and that's what the submitter seems to have tested with. >> -BROKEN_armv6= fails to compile: stack overflow >> BROKEN_armv7= fails to compile: stack overflow > > So it was fixed on armv6? BROKEN messages look suspiciously identical > to suggest that both v6/v7 builds suffered from the same error, yet > BROKEN_armv7 is still there; no explanation provided in the commit log. Yep, v6 builds fine, as was documented in the PR. ARMv7 wasn't tested, feel free. Steve