From nobody Wed Oct 1 12:18:55 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ccDVm1Hsjz69WHv; Wed, 01 Oct 2025 12:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ccDVm0Rwxz3kTS; Wed, 01 Oct 2025 12:18:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759321136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HSSXbYw9X7paVhjAqJKjjGR+7tmv6JQ2PWW/0DY5tm8=; b=oGWIu9MJtKYBWOH3V4egb2oUnKwerPIoOw16VPyHKFCyFKm0C4evbIjBOwtDYoSQ4io5z9 obSSwzkopbZvKvmAVIDhEYyLCVX5ospJtVeHjMHOY9en/QU6kmx9JMGVUZFeEXRFIRum79 YDx0N6Kb9XujMqM0Er7ryivYvQiHl+Y2BZt2xOo6yvK1vSfH2T6zPK+NSjDU4Zm3V6wT00 3nC/pS33/uUknAU9+w42A60bNlb7jTHx4xCKZIq/qJbUN81fTW1g6hB25Q0ZiGzs2M13m5 yY+kKkdEL5PLdPqMN9c5VVcm0cu5aSCzwe04g3Tc7Hab6dR+RtF5Gufj9gk+uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759321136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HSSXbYw9X7paVhjAqJKjjGR+7tmv6JQ2PWW/0DY5tm8=; b=i6kGMchM7Uu86rzTzD1ouoOMzaZmMxWU3naBLgMO5Ya+WMP/dZV+kZSlOtcKsREHMZPZtm tp0ZD+v9QjPugIuHm/Aflysiu67RicKYCDB3iFtawVa3rEg0oiBnxCCMrAsc/jYVEHrGU8 4V82ceG3mnmXLNP4lVJrWwLHv8IqnI9UTdkOtyABVsFAy7RJoLGdt1wNrjY44p3rWYXb5k d9kIaz510oCm0gc5mgNhFx/QIcLCYmWTWcXZqyG38v/SktX6bT1Ad5ML9Hy+qjFNFbQK7O AvjzEzAVaCVdHOh8KcbBYUb6d+ASTMqwCy90B2jRhEKG8psA85GSy9TuMe3ZZg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759321136; a=rsa-sha256; cv=none; b=xLLqcGUS05tS9qZj7D8lVXFOUL9hSg3p9bcGtyjGzRjceKUoidJ+ouy/e5Ljbv8FxmuUqQ LFiyMi0q6WlNJyj73g5VF4UK6yfIG7Asn7xbCDziI2UibwQRhaL52wls4bGpLbYpqZRCS8 Rt8kvLYADzcKmb82JXrglttFXOylk5GAR0BZBxgNXzAvjtRBkNYcQam5Pvx3wacPjFxyoo g6b8ykPSmkMN62f1paJkYGgHDbNRjcUjk8CdOY4+Ye2fORRfHwXr8v/WgwzVHTIRrv+nMN S5U5WeCbVPYAblCkrIYidDHab4joDhPMm9yOYkBIR6eaOaMNhIyCxza7haZCqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ccDVl6X9sz64R; Wed, 01 Oct 2025 12:18:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 591CItdJ021677; Wed, 1 Oct 2025 12:18:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 591CItrX021674; Wed, 1 Oct 2025 12:18:55 GMT (envelope-from git) Date: Wed, 1 Oct 2025 12:18:55 GMT Message-Id: <202510011218.591CItrX021674@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: bdb205c53ed7 - main - libpfctl: fix memory leak in pfctl_get_status() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bdb205c53ed769ad9f5e8da1ec6d05c48992dbf8 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=bdb205c53ed769ad9f5e8da1ec6d05c48992dbf8 commit bdb205c53ed769ad9f5e8da1ec6d05c48992dbf8 Author: Kristof Provost AuthorDate: 2025-10-01 09:41:25 +0000 Commit: Kristof Provost CommitDate: 2025-10-01 12:09:39 +0000 libpfctl: fix memory leak in pfctl_get_status() Remember to also free ncounters. Fixes: c00aca9a71 ("pf: Show pf fragment reassembly counters.") MFC after: 3 days Sponsored by: Rubicon Communications, LLC ("Netgate") --- lib/libpfctl/libpfctl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libpfctl/libpfctl.c b/lib/libpfctl/libpfctl.c index 4b579de38ad0..8c4b26b98054 100644 --- a/lib/libpfctl/libpfctl.c +++ b/lib/libpfctl/libpfctl.c @@ -561,6 +561,10 @@ pfctl_free_status(struct pfctl_status *status) free(c->name); free(c); } + TAILQ_FOREACH_SAFE(c, &status->ncounters, entry, tmp) { + free(c->name); + free(c); + } free(status); }