From owner-svn-src-all@freebsd.org Fri Jan 31 21:17:55 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0F6721ED041; Fri, 31 Jan 2020 21:17:55 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 488VS26Zhbz4Dr5; Fri, 31 Jan 2020 21:17:54 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f45.google.com with SMTP id p8so7927586oth.10; Fri, 31 Jan 2020 13:17:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=YZ/hvx4MZ15Y/tnWPnLRUa4TzxHZxAcsrAtNMuBAEuE=; b=e9cKupNAeTjinmR1M4eoil6dIkpKv/XjaZHcxLDHoG4Kn2mEn3Kbw8tUQ+9w/YsWak xXAqLqVASjV5wdtu3ah/MbPS0ej8XVmlltL/LGdhhlX/eT085YCQeedhfEUP1QNecydT iEG6MBsuVPHneHrZx/jnANte3Wh9c06prgqIT/MStUhnr2vw61qFK3J4nYeXo5yJpXLE Xb40U/nM8OkENVmnGHWrPM4dri0EFLvIDrnjsYMucdGvuq5mwvCRR90mZhTGSkfehppc wAqYgdBRzslYAOvTHAOOCeWNPc+I9WVA8wQHzKCqPqxacrwnEZxeNUtFOb7pi5mB2pKd 2lpQ== X-Gm-Message-State: APjAAAUfx1NdCyNOkwxCVPjEnAjV5x1D0c/Wav2cS1BMt69218KrWApc w1elLQgMmvzuOr7779kfbKQ0jvtG X-Google-Smtp-Source: APXvYqziiCNtCNR1xherQQYj2La14CUzViw6BHZpFLsz1rOCUCBAUaNtFOyW4UH/7H9vr3ZIfnx/lQ== X-Received: by 2002:a9d:146:: with SMTP id 64mr9120790otu.39.1580505473228; Fri, 31 Jan 2020 13:17:53 -0800 (PST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com. [209.85.167.181]) by smtp.gmail.com with ESMTPSA id z21sm3415361oto.52.2020.01.31.13.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2020 13:17:53 -0800 (PST) Received: by mail-oi1-f181.google.com with SMTP id q81so8747258oig.0; Fri, 31 Jan 2020 13:17:52 -0800 (PST) X-Received: by 2002:aca:2b0a:: with SMTP id i10mr7771131oik.137.1580505472666; Fri, 31 Jan 2020 13:17:52 -0800 (PST) MIME-Version: 1.0 References: <202001311749.00VHnFb7090545@repo.freebsd.org> In-Reply-To: <202001311749.00VHnFb7090545@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Fri, 31 Jan 2020 13:17:41 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r357337 - head/sys/riscv/include To: John Baldwin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 488VS26Zhbz4Dr5 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jan 2020 21:17:55 -0000 Hi John, Isn't the 32-bit MSTATUS_SD and SSTATUS_SD also UB without explicit unsigned suffix? Best, Conrad On Fri, Jan 31, 2020 at 9:49 AM John Baldwin wrote: > > Author: jhb > Date: Fri Jan 31 17:49:15 2020 > New Revision: 357337 > URL: https://svnweb.freebsd.org/changeset/base/357337 > > Log: > Fix 64-bit value of SSTATUS_SD to use an unsigned long. > > While here, fix MSTATUS_SD to match SSTATUS_SD. > > Reviewed by: mhorne > MFC after: 2 weeks > Sponsored by: DARPA > Differential Revision: https://reviews.freebsd.org/D23434 > > Modified: > head/sys/riscv/include/riscvreg.h > > Modified: head/sys/riscv/include/riscvreg.h > ============================================================================== > --- head/sys/riscv/include/riscvreg.h Fri Jan 31 17:40:41 2020 (r357336) > +++ head/sys/riscv/include/riscvreg.h Fri Jan 31 17:49:15 2020 (r357337) > @@ -73,7 +73,7 @@ > #define SSTATUS_XS_MASK (0x3 << SSTATUS_XS_SHIFT) > #define SSTATUS_SUM (1 << 18) > #if __riscv_xlen == 64 > -#define SSTATUS_SD (1 << 63) > +#define SSTATUS_SD (1ul << 63) > #else > #define SSTATUS_SD (1 << 31) > #endif > @@ -110,8 +110,11 @@ > #define MSTATUS_VM_SV48 10 > #define MSTATUS_VM_SV57 11 > #define MSTATUS_VM_SV64 12 > -#define MSTATUS32_SD (1 << 63) > -#define MSTATUS64_SD (1 << 31) > +#if __riscv_xlen == 64 > +#define MSTATUS_SD (1ul << 63) > +#else > +#define MSTATUS_SD (1 << 31) > +#endif > > #define MSTATUS_PRV_U 0 /* user */ > #define MSTATUS_PRV_S 1 /* supervisor */