Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 10 Aug 2017 15:09:58 +0200
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Vladimir Kondratyev <vladimir@kondratyev.su>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r447657 - in head/devel: . evemu evemu/files
Message-ID:  <e436be4d-88bd-6201-54b4-acbe27e558bd@FreeBSD.org>
In-Reply-To: <aea5d09e629f416a265b45be978f512b@kondratyev.su>
References:  <201708092100.v79L0C6a099961@repo.freebsd.org> <dcb22456-064f-9f0f-cf23-28392633a586@FreeBSD.org> <aea5d09e629f416a265b45be978f512b@kondratyev.su>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qAKGPI4dJoJEdh3s0AWiFI9X5NTPtunfE
Content-Type: multipart/mixed; boundary="3bBVe3DBOCurgt7cJ6kgELNwPl0PbwwNc";
 protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Vladimir Kondratyev <vladimir@kondratyev.su>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Message-ID: <e436be4d-88bd-6201-54b4-acbe27e558bd@FreeBSD.org>
Subject: Re: svn commit: r447657 - in head/devel: . evemu evemu/files
References: <201708092100.v79L0C6a099961@repo.freebsd.org>
 <dcb22456-064f-9f0f-cf23-28392633a586@FreeBSD.org>
 <aea5d09e629f416a265b45be978f512b@kondratyev.su>
In-Reply-To: <aea5d09e629f416a265b45be978f512b@kondratyev.su>

--3bBVe3DBOCurgt7cJ6kgELNwPl0PbwwNc
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: fr

Le 10/08/2017 =C3=A0 00:04, Vladimir Kondratyev a =C3=A9crit :
> On 2017-08-10 00:37, Mathieu Arnold wrote:
>> Le 09/08/2017 =C3=A0 23:00, Vladimir Kondratyev a =C3=A9crit :
>>> +CATEGORIES=3D     devel
>>
>> There is a whitespace violation here, it seems there are spaces and no=
t
>> tabs after the =3D.
>>
>>> +USES=3D        tar:xz python:2,build pathfix libtool pkgconfig local=
base
>>> +
>>> +PYTHON_RUN_DEPENDS=3D        ${PYTHON_CMD}:${PYTHON_PORTSDIR}
>>
>> This is a bit awful, it should probably better be:
>> PYTHON_USES=3D    python:2
>> PYTHON_USES_OFF=3D    python:2,build
>
> Hi, Mathieu
>
> I had build-tested above-mentioned changes with poudriere and got 'no
> pkg-list issues' with PYTHON option in both ON and OFF states
>
> Do you approve attached patch?


Well, the attached patch seems fine, you will need your mentors approval
for it, though :-)


--=20
Mathieu Arnold



--3bBVe3DBOCurgt7cJ6kgELNwPl0PbwwNc--

--qAKGPI4dJoJEdh3s0AWiFI9X5NTPtunfE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJZjFsyXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IfVgP+gOO0aKTWj4dGInZuEX32oFN
8kju+gIuR8IabFPl9TrcQuDAIOGADy/jmF3O3f+Kfi09klpDzMWxKditcXV4JPSs
XT6eZaVakYAhYvaTmQaxrmp46n68oBM0kBJAJ53VGQUsF+NAuJAG/7E9ui4A+GY+
T6M4LkFRltqUGBIDzVHCF0kRZ4M3kclAXA/boXYsOc2Jizdo0KpVzZ40CqRy9BUb
Qvp5cvrkBAk98njmMa5RsHu4gdEaOQjdCTOYdnNcf0mQtiSANvR62haoIBWy/Yf2
gNlci/eK9xDOPpAZ9ZSXCIsxM9aobKjDCn0LDLOtA1sxmTbn+MaTSPybBJEH8mxl
/AfzTrXTj8938PNLL0O4PED9ORF1X9JGkwZrr6CBSYLMmx/XveCDMvYD77zzCvGp
OIjrlOTtCMC+RK2sarJe/2IOs+QUkfpEUhKJwvdby6EqUCT7pbJAcCquPdGFzbcu
5A263ecggldkN6RBAfC4cLaj6AAAYNE09bHC8FhPH9YCbjzR3JUDq7YLVeYPeI6c
NwUIBNc0dniIcy3wnJNJPW9ocJjpGoH6pSN3e3XBlKj2jvcyVvlajZ+nW6TKNG+X
Gi/oTYxGg+QBAc371KcE3veJAuZm6YS1Z82RSI7Kx24ykMB/kuUPyhWrBN3xW/LB
PkPUkfE2g6pbGddvbjwQ
=skvi
-----END PGP SIGNATURE-----

--qAKGPI4dJoJEdh3s0AWiFI9X5NTPtunfE--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e436be4d-88bd-6201-54b4-acbe27e558bd>