From owner-svn-src-all@FreeBSD.ORG Wed Feb 23 14:22:35 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C632106566C; Wed, 23 Feb 2011 14:22:35 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe01.c2i.net [212.247.154.2]) by mx1.freebsd.org (Postfix) with ESMTP id 363FF8FC18; Wed, 23 Feb 2011 14:22:33 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=Vlw5OJcoxCC473z5moizI40ESYe+BpcMN2hU0iQoJwI= c=1 sm=1 a=RYRI7fz3UMUA:10 a=N659UExz7-8A:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=6I5d2MoRAAAA:8 a=a1r7yMRcHH9g8YGSE6wA:9 a=lw16Ru0DRNIL3o3H9-jNLSPc8UsA:4 a=pILNOxqGKmIA:10 a=i9M/sDlu2rpZ9XS819oYzg==:117 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mailfe01.swip.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 X-TFF-CGPSA-Version: 1.7 X-T2-CGPSA-Filter: Scanned Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe01.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 92284064; Wed, 23 Feb 2011 15:22:20 +0100 From: Hans Petter Selasky To: Alexander Best Date: Wed, 23 Feb 2011 15:22:02 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; ) References: <20110223131228.GN78089@deviant.kiev.zoral.com.ua> <20110223135734.GA62693@freebsd.org> In-Reply-To: <20110223135734.GA62693@freebsd.org> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201102231522.02362.hselasky@c2i.net> Cc: Kostik Belousov , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , John Baldwin Subject: Re: svn commit: r218967 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2011 14:22:35 -0000 On Wednesday 23 February 2011 14:57:34 Alexander Best wrote: > On Wed Feb 23 11, Kostik Belousov wrote: > > On Wed, Feb 23, 2011 at 12:56:25PM +0000, John Baldwin wrote: > > > Author: jhb > > > Date: Wed Feb 23 12:56:25 2011 > > > New Revision: 218967 > > > URL: http://svn.freebsd.org/changeset/base/218967 > > > > > > Log: > > > Fix off-by-one error in check against max_threads_per_proc. > > > > > > Submitted by: arundel > > > MFC after: 1 week > > > > > > Modified: > > > head/sys/kern/kern_thr.c > > > > > > Modified: head/sys/kern/kern_thr.c > > > ======================================================================= > > > ======= --- head/sys/kern/kern_thr.c Wed Feb 23 10:28:37 2011 (r218966) > > > +++ head/sys/kern/kern_thr.c Wed Feb 23 12:56:25 2011 (r218967) @@ > > > -153,7 +153,7 @@ create_thread(struct thread *td, mcontex > > > > > > p = td->td_proc; > > > > > > /* Have race condition but it is cheap. */ > > > > > > - if (p->p_numthreads >= max_threads_per_proc) { > > > + if (p->p_numthreads > max_threads_per_proc) { > > > > > > ++max_threads_hits; > > > return (EPROCLIM); > > > > > > } > > > > I do not think there was off by one error. The create_thread() function > > is called to create new thread, and before the process thread counter > > is incremented in thread_link(). The old test tried to not allow more > > then max_threads_per_proc threads in a process, now it allows to > > create max_threads_per_proc. > > doesn't the semantics of the term "maximum" imply that it's own value is > also valid? > > if a sign says maximum weight 2000kg, does that mean that a weight of > 2000kg is invalid and the highest valid weight is 1999,999..kg? Hi, The sign should have used terms like EQ and GTE and LTE and a granularity. Obviously not all people writing important numerical information are programmers ;-) --HPS