From owner-cvs-all Fri Mar 2 14:30:18 2001 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67]) by hub.freebsd.org (Postfix) with ESMTP id 72A9537B719; Fri, 2 Mar 2001 14:30:10 -0800 (PST) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.11.2/8.9.3) id f22MTaY09899; Fri, 2 Mar 2001 14:29:36 -0800 (PST) (envelope-from dillon) Date: Fri, 2 Mar 2001 14:29:36 -0800 (PST) From: Matt Dillon Message-Id: <200103022229.f22MTaY09899@earth.backplane.com> To: Garrett Wollman Cc: Jonathan Lemon , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c References: <200103012339.f21NdW309088@freefall.freebsd.org> <15006.60555.97100.465265@nomad.yogotech.com> <20010301184258.T25974@prism.flugsvamp.com> <15006.61041.727634.597339@nomad.yogotech.com> <200103020236.VAA06356@khavrinen.lcs.mit.edu> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :< said: : :> } When iterating over our list of interface addresses in order to determine :> } if an arriving packet belongs to us, also check that the packet arrived :> } through the correct interface. Skip this check if the packet was locally :> } generated. : :This change is bogus and breaks multihomed hosts. Please back it :out. While RFC 1122 states (3.3.4.2): I'm not sure I understand how the commit changes anything. If a packet arrives on an interface with a destination address that does not match the interface's address or aliases, and we aren't in promiscuous mode, won't the controller reject the packet anyway? The kernel will never see it in the first place. Right? -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message