From owner-svn-src-head@FreeBSD.ORG Mon Dec 12 10:20:43 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5A48F106564A; Mon, 12 Dec 2011 10:20:43 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 3C8288FC15; Mon, 12 Dec 2011 10:20:41 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA18621; Mon, 12 Dec 2011 12:20:39 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Ra2zu-000I4v-Ve; Mon, 12 Dec 2011 12:20:39 +0200 Message-ID: <4EE5D574.9080303@FreeBSD.org> Date: Mon, 12 Dec 2011 12:20:36 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111206 Thunderbird/8.0 MIME-Version: 1.0 To: Kostik Belousov References: <201112121005.pBCA5Dar093711@svn.freebsd.org> <20111212101558.GK50300@deviant.kiev.zoral.com.ua> In-Reply-To: <20111212101558.GK50300@deviant.kiev.zoral.com.ua> X-Enigmail-Version: undefined Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228433 - in head/sys: kern security/mac X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2011 10:20:43 -0000 on 12/12/2011 12:15 Kostik Belousov said the following: > On Mon, Dec 12, 2011 at 10:05:13AM +0000, Andriy Gapon wrote: >> Author: avg >> Date: Mon Dec 12 10:05:13 2011 >> New Revision: 228433 >> URL: http://svn.freebsd.org/changeset/base/228433 >> >> Log: >> put sys/systm.h at its proper place or add it if missing >> >> Reported by: lstewart, tinderbox >> Pointyhat to: avg, attilio >> MFC after: 1 week >> MFC with: r228430 >> >> Modified: >> head/sys/kern/kern_sx.c >> head/sys/kern/vfs_cache.c >> head/sys/security/mac/mac_framework.c >> head/sys/security/mac/mac_priv.c > It means that previously sx.h did not required systm.h and now it does ? > Might be, you should move SCHEDULER_STOPPED and stop_scheduler declarations > into sys/lock.h ? > Strictly speaking it's sys/lockstat.h that now requires systm.h. I am not an expert in FreeBSD header file organization, so I will just follow whatever the experts advise. -- Andriy Gapon