From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:23 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9A0C716A4CE for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8631143D45 for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eN4r086931 for ; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eNk7086930; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:23 GMT Resent-Message-Id: <200409120240.i8C2eNk7086930@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5259716A4CE for ; Sun, 12 Sep 2004 02:37:33 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F16643D45 for ; Sun, 12 Sep 2004 02:37:32 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bUPN007093 for ; Sun, 12 Sep 2004 04:37:30 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bUP3007092 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:30 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2bUP3007092@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:30 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71616: [PATCH] cleanup of the usr.sbin/yp_mkdb code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:23 -0000 >Number: 71616 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/yp_mkdb code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:23 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 $FreeBSD: src/usr.sbin/yp_mkdb/yp_mkdb.c,v 1.16 2003/05/03 21:06:41 obrien >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/yp_mkdb/yp_mkdb.c:90: warning: char format, void arg (arg 3) usr.sbin/yp_mkdb/yp_mkdb.c:90: warning: char format, void arg (arg 5) usr.sbin/yp_mkdb/yp_mkdb.c:221: warning: long unsigned int format, time_t arg (arg 4) usr.sbin/yp_mkdb/yp_mkdb.c:221: warning: long unsigned int format, time_t arg (arg 4) >How-To-Repeat: N/A >Fix: *** usr.sbin/yp_mkdb/yp_mkdb.c.ORIG Sun Sep 5 18:54:07 2004 --- usr.sbin/yp_mkdb/yp_mkdb.c Sun Sep 5 19:01:20 2004 *************** *** 87,93 **** key.data = NULL; while (yp_next_record(dbp, &key, &data, 1, 1) == YP_TRUE) ! printf("%.*s %.*s\n", key.size,key.data,data.size,data.data); (void)(dbp->close)(dbp); return; --- 87,94 ---- key.data = NULL; while (yp_next_record(dbp, &key, &data, 1, 1) == YP_TRUE) ! printf("%.*s %.*s\n", key.size, (char *)key.data, ! data.size, (char *)data.data); (void)(dbp->close)(dbp); return; *************** *** 218,224 **** key.data = "YP_LAST_MODIFIED"; key.size = sizeof("YP_LAST_MODIFIED") - 1; ! snprintf(buf, sizeof(buf), "%lu", time(NULL)); data.data = (char *)&buf; data.size = strlen(buf); yp_put_record(dbp, &key, &data, 0); --- 219,225 ---- key.data = "YP_LAST_MODIFIED"; key.size = sizeof("YP_LAST_MODIFIED") - 1; ! snprintf(buf, sizeof(buf), "%lu", (long unsigned int)time(NULL)); data.data = (char *)&buf; data.size = strlen(buf); yp_put_record(dbp, &key, &data, 0); >Release-Note: >Audit-Trail: >Unformatted: