From owner-svn-src-head@freebsd.org Sat Jun 24 19:54:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4AADFDA4B12; Sat, 24 Jun 2017 19:54:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 14CBB7736D; Sat, 24 Jun 2017 19:54:28 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x244.google.com with SMTP id e199so1639047pfh.0; Sat, 24 Jun 2017 12:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=N6MX5OitIXEj2pH67f0Q98V5fz+DuHsLIpv4mgMpQx0=; b=b5348gaWNLg/IRz5Cb6K6zCuvyD2HdlphsPkfgf8EpGW2jQgXorFe92mLkujUh81tV s09hjUsoFzBhWHa6hknMwNzPsxz+ZBI3WM/MZPkue8HSfSLdPkNBp6N2O8orByMy2C9A oan+6d/UbrUmty8V9vH1wLqaZ+NWLlo37ouxjWSHR4lo2+9zArUwFPJVnaosoKOvzy8F uUofvOMuNKrD1ODOkdNYFwvqmlWPKKvm+1jpGZWii+PA7fkYKnarksSULJz9XiCdp5uA zvhhTbAYB98NoiEhGUgDQwWXEvYOGRFAURXzIaJTxgPrPwoUL9bk8sdsmClVm2cbqhn7 5mQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=N6MX5OitIXEj2pH67f0Q98V5fz+DuHsLIpv4mgMpQx0=; b=lm5mp1ojm67GGlunRyH/bxZbA2xzd7UI1gEE8ymoxulyEJL5XH87CYQWNezZ8GMMwB ht302+tbzpxXSY21y0jv7ebBMVDd48eFIR9xXQeshcyCmE2ycDwA3DelS9vgiin/ETJ6 EpLNDI5MIj7LWu7ODv9r2aPpt8Gm75qqyrqVwddgKZBUYgds2US1ShwMusx/bVk/t/jI RYSt4+otqZeNsLyegwiy2d2dR0MucLRZldEPbj2Mo5e7PRJ4SKtmIJI1YOczSmDURSUB CgD01/Ixy5gYR7zJdwo2ay+JkCFjeuYd9ouw7dnGDj2rtGTJAL5hgDRjypNOkdCa4Zh7 5Big== X-Gm-Message-State: AKS2vOwJjnC+5jkGTwADeyYz380JJ0RSLGhbqE7D6XMK0vIyvos+oo6h TbE/Nc0pYseM5rwdZHU= X-Received: by 10.99.188.18 with SMTP id q18mr14234293pge.79.1498334067267; Sat, 24 Jun 2017 12:54:27 -0700 (PDT) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id 24sm17438797pfs.58.2017.06.24.12.54.24 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Jun 2017 12:54:25 -0700 (PDT) Subject: Re: svn commit: r320277 - head/usr.bin/mkuzip Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_5EEAB819-08EB-4E1A-95C1-907ECE064877"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170623235139.GA69426@FreeBSD.org> Date: Sat, 24 Jun 2017 12:54:23 -0700 Cc: Conrad Meyer , Maxim Sobolev , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201706231739.v5NHd05x039900@repo.freebsd.org> <20170623235139.GA69426@FreeBSD.org> To: Glen Barber X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jun 2017 19:54:28 -0000 --Apple-Mail=_5EEAB819-08EB-4E1A-95C1-907ECE064877 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Jun 23, 2017, at 16:51, Glen Barber wrote: >=20 > On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote: >>> @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp) >>> ffd =3D open(statfsbuf.f_mntfromname, O_RDONLY); >>> if (ffd < 0) { >>> warn("open(%s, O_RDONLY)", = statfsbuf.f_mntfromname); >>> + close(ffd); >>=20 >> This one is wrong for obvious reasons. >>=20 >=20 > It isn't obvious to me. :) open failed, so closing ffd =3D=3D -1 is a programming error (but = admittedly, pretty benign). -Ngie --Apple-Mail=_5EEAB819-08EB-4E1A-95C1-907ECE064877 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZTsNwAAoJEPWDqSZpMIYVbZMP/iG9rupG6A1N+NMah71sYrjb 6jsgJWN85OvN5ZncNBfNg85Yru1qENQbS863WlJ4k7yRVrXWqp3Sj18XNu8lpyKR P0YdQKgGLVI0pDpaaux5OYTYsjdDNU6M+z9QMdmDHVeJtnMEZKHrZwf7xzMGnJZu q6F5dMisVS8HTTXol5R/0Ym/nQgp/6B+5Xj2Z5bpsI4x1pYtI0wuEN0CaSO1WWzq hN1Fgbxgp9K+fBmFuzU5F9x5J5ryTSLgTD4k8AhLCzrY780wXnUyOf6idrrKowF4 T8G9c7JR1B8dTqniVbNYB6dtiMB3z/lzc8FG5FosDIIaEJvFTTyvGgjLj/Y3VzXK Fqthda9DkGGuZceec9EqyDNS9eOWD9uaOJQV+vffyuSQ4V83TtXNyOsqudw4onkb 5Vn9dMemCm5dyEpSuns+SDAMeFf5JJtAUcoyq+SkBWZqIHbtpsaNELU7MGfVTfNj DkrvMDRNycVU1TXlMAfbvdlzykW+2Jo5RJ0EOY4gRukneARI5p2dEOKQii9Ox5aM tNoEfu4Ykp6gP+WciRKOGDH1Bz2ar8/XkUVGcsXsin8lLHqmyZZGCRhnidBsqYQs Vz89II6vR90ogZXNr7Bxv6bKR9pgY03Vu62C8FtxiiRG1kpI0cD1hSPNp3pVCmtH cDhtf7aXR9fiuHzHU+gZ =48rq -----END PGP SIGNATURE----- --Apple-Mail=_5EEAB819-08EB-4E1A-95C1-907ECE064877--