From owner-svn-src-all@freebsd.org Thu Mar 17 04:55:47 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 287C1AD3060; Thu, 17 Mar 2016 04:55:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0929AAA; Thu, 17 Mar 2016 04:55:46 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ob0-x22e.google.com with SMTP id m7so72454232obh.3; Wed, 16 Mar 2016 21:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=kA0HEdGYXEu+pu2+WIQaWW9QTNmhXK9AoifDg0OGkt0=; b=o6mRltbH0/5McGoz/1HsTDxwGiVWkVAtJFRekkYtDTCvNsMRLDF8Sqou8GfGuaF2ZF 4NGYIrVSTJqtURumSUsIFKVuSzWn5DwTHp+F4IFg6aSzVzIMjY72gzPdPKDboIdHtPVp 36/Et1ETgNmycQJ2Cl+uDnqoH2lNllWTzWEIltnNzn01PLAUWyjS9zR5BL/AG/QpxbJr aBD5wYlbUqiTlkyUf2JlkWH9YpPJRNhKRmOsmQrVhXqU0GkJ8+hP+onFTx+55JboJDJU 1PxwgVUvMIMmk4g9Yaam5Zoj0F16c1cp3JYMGCzSrPr7OcIneCqAnZmtbHrBJBdEU9SN +3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=kA0HEdGYXEu+pu2+WIQaWW9QTNmhXK9AoifDg0OGkt0=; b=KBWYto25UgnhG35AGhEipsXZhe6QQWolJhWQSrgw38OWMWoo8sYitVAEIqHphYmL4O xkKp6kc3DQxH4cehYbSltmg+wd0bYlQEHOEXgXbsXnfiPiP25vjCwgDKRXLBI5wsV2VW 8md+6llAav87siZuWIV6PYzIZL5S6OzWPMQQjjmNJ1ClFRSoW6HkVAYXL1PZ0j01uNbK EfAIryOAs+edUwEvKqbaOjYBAKgU0WU+3DR1d8c0sVeWz0iZmQ4uiXMYwUrI0fRJdGQU veHiyd/3oYCNqyQC8dAVlfalwg4lIkrfvPkIyGKmyBJdKByRzk0Cke/WQinAKJFJR2gt Jyvw== X-Gm-Message-State: AD7BkJInQKarLrglCLZvjYDxoulujH1TClCNmZglrXiJdf1KTCcPgdg3uXBj0iIK4DLKBDIfbHFwVE4wUvjJuA== MIME-Version: 1.0 X-Received: by 10.182.66.169 with SMTP id g9mr4739304obt.49.1458190546055; Wed, 16 Mar 2016 21:55:46 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.64.138 with HTTP; Wed, 16 Mar 2016 21:55:45 -0700 (PDT) In-Reply-To: References: <201509040014.t840ELno034811@repo.freebsd.org> Date: Wed, 16 Mar 2016 22:55:45 -0600 X-Google-Sender-Auth: e9JOjh0UpEdR7jN-9vhMJ9-P0bI Message-ID: Subject: Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools From: Alan Somers To: Sean Fagan Cc: Xin LI , Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 04:55:47 -0000 Do you happen to know if ACL_ENTRY_INHERITED is written to disk, or does it only exist in-core? On Wed, Mar 16, 2016 at 10:37 PM, Sean Fagan wrote: > As I recall, from ZFS, but I=E2=80=99m not positive. Either that, or som= ething > else was using 0x40. > > Sean. > > On Mar 16, 2016, at 9:29 PM, Xin LI wrote: > > > > +sef who created the patch... > > > > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers > wrote: > >> > >> > >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: > >>> > >>> Author: delphij > >>> Date: Fri Sep 4 00:14:20 2015 > >>> New Revision: 287445 > >>> URL: https://svnweb.freebsd.org/changeset/base/287445 > >>> > >>> Log: > >>> Expose an interface to determine if an ACE is inherited. > >>> > >>> Submitted by: sef > >>> Reviewed by: trasz > >>> MFC after: 2 weeks > >>> Differential Revision: https://reviews.freebsd.org/D3540 > >>> > >>> Modified: > >>> head/bin/setfacl/setfacl.1 > >>> head/lib/libc/posix1e/acl_add_flag_np.3 > >>> head/lib/libc/posix1e/acl_support_nfs4.c > >>> head/share/man/man9/acl.9 > >>> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c > >>> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h > >>> head/sys/kern/subr_acl_nfs4.c > >>> head/sys/sys/acl.h > >>> head/tools/regression/acltools/tools-crossfs.test > >>> head/tools/regression/acltools/tools-nfs4-psarc.test > >>> head/tools/regression/acltools/tools-nfs4-trivial.test > >>> head/tools/regression/acltools/tools-nfs4.test > >> > >> > >> ... > >> > >>> > >>> Modified: head/sys/sys/acl.h > >>> > >>> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > >>> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015 (r287444) > >>> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015 (r287445) > >>> @@ -249,11 +249,12 @@ typedef void *acl_t; > >>> #define ACL_ENTRY_INHERIT_ONLY 0x0008 > >>> #define ACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 > >>> #define ACL_ENTRY_FAILED_ACCESS 0x0020 > >>> +#define ACL_ENTRY_INHERITED 0x0080 > >>> > >>> #define ACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERI= T > | > >>> \ > >>> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ > >>> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ > >>> - ACL_ENTRY_FAILED_ACCESS) > >>> + ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) > >>> > >>> /* > >>> * Undefined value in ae_id field. ae_id should be set to this value > >> > >> > >> Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED > instead > >> of 0x0040 ? > >> > > > > > > > > -- > > Xin LI https://www.delphij.net/ > > FreeBSD - The Power to Serve! Live free or die > >