From owner-cvs-all  Thu Feb 28 11:35:26 2002
Delivered-To: cvs-all@freebsd.org
Received: from tao.org.uk (genius.tao.org.uk [212.135.162.51])
	by hub.freebsd.org (Postfix) with ESMTP
	id F1E1837B430; Thu, 28 Feb 2002 11:35:15 -0800 (PST)
Received: by tao.org.uk (Postfix, from userid 100)
	id EACAD4A7; Thu, 28 Feb 2002 19:34:48 +0000 (GMT)
Date: Thu, 28 Feb 2002 19:34:48 +0000
From: Josef Karthauser <joe@tao.org.uk>
To: Julian Elischer <julian@elischer.org>
Cc: peter@freebsd.org, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/usb ohci.c
Message-ID: <20020228193448.GC15224@genius.tao.org.uk>
References: <20020228184733.GB15224@genius.tao.org.uk> <Pine.BSF.4.21.0202281056200.6492-100000@InterJet.elischer.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd"
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.21.0202281056200.6492-100000@InterJet.elischer.org>
User-Agent: Mutt/1.3.27i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--i7F3eY7HS/tUJxUd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 28, 2002 at 10:58:02AM -0800, Julian Elischer wrote:
>=20
> > > >   Modified files:
> > > >     sys/dev/usb          ohci.c=20
> > > >   Log:
> > > >   Add a comment explaining a code change..
>=20
> OK but we needed to get the kernel compiling again.
> The comments were because it wasn't obvious why the change was made
> and I could see that it would be reverted at the first oportunity without
> it..
>=20

Sorry if I came over snotty.  I'm pretty responsive you'll find, and if
you'd like to bounce patches off me, as others are doing, I'd be very
grateful.

> Any movement on the fact that the usb code allocates 2K+ on the stack?

Yes, I've got patches to fix this.  It will be committed at some point,
don't worry.

Joe

--i7F3eY7HS/tUJxUd
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjx+hlgACgkQXVIcjOaxUBa/CACgw7PWfQgFSOLavAbdOXDuo0Gm
OZgAoLfg0fqLS5+y0yrzEzlSzyMQFpi7
=K/jI
-----END PGP SIGNATURE-----

--i7F3eY7HS/tUJxUd--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message