From owner-svn-src-head@freebsd.org Thu Jan 14 09:58:29 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E13ADA80673 for ; Thu, 14 Jan 2016 09:58:29 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 805161AF3 for ; Thu, 14 Jan 2016 09:58:29 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x235.google.com with SMTP id l65so333666022wmf.1 for ; Thu, 14 Jan 2016 01:58:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=fR216apaZOyHWW+fqryXEWNnqod7dqCK+YkcrlcuaVE=; b=D797hZ74n1unU0q5Fq+xMyNhAvE5iRIP9FPPfJiuhpD2ib9V86tazB73ULf365FKxM ntqmJ1/nPh3s/PFudvw7vvTEm84d28jvHAirkoWn5+34AxFOm+FjHtd/BKHGQgjfO+aw N+g2d2GUT6fP9A9TfDUq0R49070JFIpqeNi+VQPih/cfylfkuJVSIyShgMlH8Fbcmm0J L2DBuInsgDan9+FZScc38hjBhnX83IS77+pwFW7NGAUYSI9k+mhXm4OB8HVE/rpoxNd0 Xe2rsBXxXlbnWMzbEkVZ1KjCqqLwT7QuZP9qUBW+rm2cF2T6DPCZwRaVEIDsQ/zVoxQQ GPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=fR216apaZOyHWW+fqryXEWNnqod7dqCK+YkcrlcuaVE=; b=btprb3F1dPKBoBfdMsY2ePW6v9Gf5T1qDNWXyBS85NcN02AfVJpu06BhwvVSEWfI89 i1Huz1Bq+SdATdJg+uINyNovpQbCzQAq7cDnoj8q9et+auz1u6qIlO+PY0/hhb9Y/wYs WoN/5PebQzg5yb2bzTu3aPabKJ4/03G6Mz0txUZF7418+6ap04wsuqS9WXt++Lrrrdig 938kqMEwznbD/Kc6CdswJIAxAB/e3qQ5oxbanFMOjDNLq/zX5ImuQRLFy1RPpQT1Vnyr x2okq0iQFGWF7cr1OpcThZN8phtMMwdlm10o+jWN/p9zgrIRm+t77O1pw4dI9y6ccSkQ WC0A== X-Gm-Message-State: ALoCoQl8qjTS7QbgISTBGWkNVaItjLJ614BCvr0ewy8Ky67CU3JOp+U4fqB9mUjAPzGgOr7Nh7SEvWRkDnuRAPzBXHmQ1I8OuQ== X-Received: by 10.194.92.8 with SMTP id ci8mr3027296wjb.33.1452765507926; Thu, 14 Jan 2016 01:58:27 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id l67sm26026386wmf.11.2016.01.14.01.58.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 01:58:27 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r293903 - in head/sys/boot: arm/uboot efi/fdt efi/libefi To: NGie Cooper References: <201601140922.u0E9M1rV025146@repo.freebsd.org> <9A7534C4-0A2C-4DAC-981A-09868F1723DA@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <56977155.3040507@freebsd.org> Date: Thu, 14 Jan 2016 09:58:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <9A7534C4-0A2C-4DAC-981A-09868F1723DA@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 09:58:30 -0000 On 14/01/2016 09:47, NGie Cooper wrote: >> On Jan 14, 2016, at 01:27, NGie Cooper wrote: >> >> >>> On Jan 14, 2016, at 01:22, Steven Hartland wrote: >>> >>> Author: smh >>> Date: Thu Jan 14 09:22:01 2016 >>> New Revision: 293903 >>> URL: https://svnweb.freebsd.org/changeset/base/293903 >>> >>> Log: >>> Fix GCC warnings causing build failure after r293724 >>> >>> Disable some compiler warnings for GCC (non-standard compiler) fixing >>> build failures introduced by r293724, which enabled WARNS in the EFI boot >>> code, when compiling with none standard compiler (GCC). >> Disabling warnings is wrong. Here’s how arm could be fixed: >> >> $ svn diff sys/boot/ >> Index: sys/boot/common/bootstrap.h >> =================================================================== >> --- sys/boot/common/bootstrap.h (revision 293877) >> +++ sys/boot/common/bootstrap.h (working copy) >> @@ -32,6 +32,7 @@ >> #include >> #include >> #include >> +#include >> >> /* >> * Generic device specifier; architecture-dependant >> @@ -332,12 +333,8 @@ >> extern struct arch_switch archsw; >> >> /* This must be provided by the MD code, but should it be in the archsw? */ >> -void delay(int delay); >> - >> void dev_cleanup(void); >> >> -time_t time(time_t *tloc); >> - >> #ifndef CTASSERT /* Allow lint to override */ >> #define CTASSERT(x) _CTASSERT(x, __LINE__) >> #define _CTASSERT(x, y) __CTASSERT(x, y) >> Index: sys/boot/efi/include/efiapi.h >> =================================================================== >> --- sys/boot/efi/include/efiapi.h (revision 293877) >> +++ sys/boot/efi/include/efiapi.h (working copy) >> @@ -532,6 +532,7 @@ >> typedef >> EFI_STATUS >> (EFIAPI *EFI_RESERVED_SERVICE) ( >> + VOID >> ); >> >> typedef >> >> amd64 is a bit trickier: >> >> /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/efigop.h:75: warning: 'ms_abi' attribute directive ignored >> >> I didn’t dig into why this is happening [yet], other than there maybe being MS extensions involved? >> >> Thanks, >> -NGie > This might fix amd64: > > Index: /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h > =================================================================== > --- /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h (revision 293877) > +++ /scratch/tmp/ngie/svn/sys/boot/efi/libefi/../include/amd64/efibind.h (working copy) > @@ -160,8 +160,10 @@ > // > > #ifdef __amd64__ > +#if defined(__clang__) && (__clang_major__ >= 3 && __clang_minor__ >= 5) > #define EFIAPI __attribute__((ms_abi)) > #endif > +#endif > > #ifndef EFIAPI // Forces EFI calling conventions reguardless of compiler options > #ifdef _MSC_EXTENSIONS > Other implementations I've seen for this only define that when it's compiling with MS VCC, so that might be the more correct fix?