From owner-freebsd-arm@FreeBSD.ORG Fri Jan 23 21:40:31 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94550DFD for ; Fri, 23 Jan 2015 21:40:31 +0000 (UTC) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gold.funkthat.com", Issuer "gold.funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A2627CC for ; Fri, 23 Jan 2015 21:40:30 +0000 (UTC) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.14.5/8.14.5) with ESMTP id t0NLeSVm010487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 23 Jan 2015 13:40:28 -0800 (PST) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.14.5/8.14.5/Submit) id t0NLeSQC010486; Fri, 23 Jan 2015 13:40:28 -0800 (PST) (envelope-from jmg) Date: Fri, 23 Jan 2015 13:40:28 -0800 From: John-Mark Gurney To: Daisuke Aoyama Subject: Re: mount_smbfs Message-ID: <20150123214028.GQ1949@funkthat.com> References: <54B9DCD1.3040306@foxvalley.net> <4759EAA0-D4AA-4923-9350-B7E753819169@me.com> <6E32991C3BD8465DB8DB0E65DFDA47AA@ad.peach.ne.jp> <20150123195403.GO1949@funkthat.com> <62AC231D96DE425FB72E0C6DA6ACBF1F@ad.peach.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62AC231D96DE425FB72E0C6DA6ACBF1F@ad.peach.ne.jp> X-Operating-System: FreeBSD 9.1-PRERELEASE amd64 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (gold.funkthat.com [127.0.0.1]); Fri, 23 Jan 2015 13:40:28 -0800 (PST) Cc: freebsd-arm@freebsd.org, Rui Paulo X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 21:40:31 -0000 Daisuke Aoyama wrote this message on Sat, Jan 24, 2015 at 06:28 +0900: > Thank you for a comment. > I didn't think about endian functions. > > >Please use {l,b}e16dec, or if the code is suppose to be native endian, > >make it dependant on __NO_STRICT_ALIGNMENT and add the proper endian > >swap, not __arm__ as there are other arches that require the same fix... > > I make a patch again for supporting BE CPU. > > man page don't mention about strict alignment, if le16enc is not using byte access, > you need expand it like this: le16enc is documented to work any alignment... from byteorder(9): The be16enc(), be16dec(), be32enc(), be32dec(), be64enc(), be64dec(), le16enc(), le16dec(), le32enc(), le32dec(), le64enc(), and le64dec() functions encode and decode integers to/from byte strings on any ^^^ alignment in big/little endian format. ^^^^^^^^^ > > + le16enc(cp, le16toh(NBENCODE(toupper(*name)))); > vvvvvv > + *(cp + 0) = le16toh(NBENCODE(toupper(*name))) & 0xffU; > + *(cp + 1) = (le16toh(NBENCODE(toupper(*name))) >> 8) & 0xffU; -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."