From owner-freebsd-current@FreeBSD.ORG Fri Oct 5 19:59:29 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7EDB16A418 for ; Fri, 5 Oct 2007 19:59:29 +0000 (UTC) (envelope-from rse@engelschall.com) Received: from visp1.engelschall.com (visp1.engelschall.com [195.30.6.144]) by mx1.freebsd.org (Postfix) with ESMTP id 73B8C13C468 for ; Fri, 5 Oct 2007 19:59:29 +0000 (UTC) (envelope-from rse@engelschall.com) Received: by visp1.engelschall.com (Postfix, from userid 21100) id 1AF351B44851; Fri, 5 Oct 2007 21:41:44 +0200 (CEST) Received: by en1.engelschall.com (Postfix, from userid 10000) id F268D6DC71; Fri, 5 Oct 2007 21:38:25 +0200 (CEST) Date: Fri, 5 Oct 2007 21:38:25 +0200 From: "Ralf S. Engelschall" To: freebsd-current@freebsd.org Message-ID: <20071005193825.GA66299@engelschall.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: FreeBSD User-Agent: Mutt/1.5.16 OpenPKG/CURRENT (2007-06-09) Subject: cosmetics: bsdlabel fstype for ZFS partitions? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Ralf S. Engelschall" List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2007 19:59:29 -0000 I've today switched the boot disk of a FreeBSD 7 system from UFS-only to UFS (/boot) plus ZFS (for /, /usr, etc). For this I the first time created a ZFS pool from a _partition_ instead of the usual whole slices or disks. In the bsdlabel(8) editing session (where I merged some of the previous UFS partitions to a single large one for ZFS) I recognized that we do not have a keyword for ZFS on the "fstype" column: | # size offset fstype [fsize bsize bps/cpg] | a: 1048576 0 4.2BSD 2048 16384 8 | b: 4142736 1048576 swap | c: 33554052 0 unused 0 0 # "raw" part, don't edit | d: 28362740 5191312 unused 0 0 ^^^^^^ I currently use "unused" here for the partition of the ZFS pool and everything works just fine, of coure. But it looks a little bit strange to me and this small cosmetic issue should be fixed IMHO. So, shouldn't we define a "zfs" filesystem type in sys/sys/disklabel.h:fstypenames plus a corresponding "#define FS_ZFS ?? /* Sun ZFS */"? If yes, what value would FS_ZFS be defined to? BTW, same for the disk type, I think. Here a numeric value certainly was already choosen, as Sun's GRUB is booting from ZFS disks, right? -- rse@FreeBSD.org Ralf S. Engelschall FreeBSD.org/~rse rse@engelschall.com FreeBSD committer www.engelschall.com