From owner-freebsd-bugs@FreeBSD.ORG  Fri Jul 16 17:30:14 2010
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2F56A1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 16 Jul 2010 17:30:14 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 04C538FC12
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 16 Jul 2010 17:30:14 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6GHUDXU064676
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 16 Jul 2010 17:30:13 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6GHUD1Q064667;
	Fri, 16 Jul 2010 17:30:13 GMT (envelope-from gnats)
Date: Fri, 16 Jul 2010 17:30:13 GMT
Message-Id: <201007161730.o6GHUD1Q064667@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/145064: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jul 2010 17:30:14 -0000

The following reply was made to PR kern/145064; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/145064: commit references a PR
Date: Fri, 16 Jul 2010 17:27:57 +0000 (UTC)

 Author: mav
 Date: Fri Jul 16 17:27:43 2010
 New Revision: 210168
 URL: http://svn.freebsd.org/changeset/base/210168
 
 Log:
   Make legacy ATA emulation detection more strict. This should fix false
   positive legacy detection and attach failure/panic for Marvell 88SX6141
   controller and potentially some others.
   
   PR:		kern/145064
 
 Modified:
   head/sys/dev/ata/ata-pci.c
 
 Modified: head/sys/dev/ata/ata-pci.c
 ==============================================================================
 --- head/sys/dev/ata/ata-pci.c	Fri Jul 16 17:01:36 2010	(r210167)
 +++ head/sys/dev/ata/ata-pci.c	Fri Jul 16 17:27:43 2010	(r210168)
 @@ -769,7 +769,8 @@ DRIVER_MODULE(ata, atapci, ata_pcichanne
  int
  ata_legacy(device_t dev)
  {
 -    return (((pci_read_config(dev, PCIR_PROGIF, 1)&PCIP_STORAGE_IDE_MASTERDEV)&&
 +    return (((pci_read_config(dev, PCIR_SUBCLASS, 1) == PCIS_STORAGE_IDE) &&
 +	     (pci_read_config(dev, PCIR_PROGIF, 1)&PCIP_STORAGE_IDE_MASTERDEV)&&
  	     ((pci_read_config(dev, PCIR_PROGIF, 1) &
  	       (PCIP_STORAGE_IDE_MODEPRIM | PCIP_STORAGE_IDE_MODESEC)) !=
  	      (PCIP_STORAGE_IDE_MODEPRIM | PCIP_STORAGE_IDE_MODESEC))) ||
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"