Date: Fri, 19 Dec 2008 20:43:58 +0300 (MSK) From: Maxim Dounin <mdounin@mdounin.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/129767: [patch] databases/memcached - extra patch for repcached to work on amd64 Message-ID: <20081219174358.52B9317048@mdounin.cust.ramtel.ru> Resent-Message-ID: <200812191750.mBJHo2Mn099462@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 129767
>Category: ports
>Synopsis: [patch] databases/memcached - extra patch for repcached to work on amd64
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 19 17:50:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Maxim Dounin
>Release: FreeBSD 7.0-RELEASE-p3 i386
>Organization:
>Environment:
>Description:
With repcached patches memcached segfaults on replication start under
amd64.
>How-To-Repeat:
Start an instance of memcached with repcached patches and place some data
into it. Start another instance with replication from the first one.
The first one will segfault (under amd64, under i386 everything is fine).
>Fix:
The following patch (against databases/memcached port) adds missing
assoc_key_snap() function prototype and fixes the problem.
--- patch-port-memcached.txt begins here ---
--- Makefile Fri Dec 19 19:47:34 2008 +0300
+++ Makefile Fri Dec 19 19:56:52 2008 +0300
@@ -39,6 +39,7 @@ PATCH_SITE_SUBDIR= repcached
PATCH_SITE_SUBDIR= repcached
PATCH_DIST_STRIP+= -p1
PATCHFILES+= repcached-2.1-1.2.6.patch.gz
+EXTRA_PATCHES+= ${FILESDIR}/extra-patch-repcached-assoc.h
CONFIGURE_ARGS+= --enable-replication --disable-threads
.endif
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ files/extra-patch-repcached-assoc.h Fri Dec 19 19:56:52 2008 +0300
@@ -0,0 +1,9 @@
+--- assoc.h.orig 2008-12-19 15:37:20.782290418 +0000
++++ assoc.h 2008-12-19 15:37:28.223146102 +0000
+@@ -5,3 +5,6 @@
+ void assoc_delete(const char *key, const size_t nkey);
+ void do_assoc_move_next_bucket(void);
+ uint32_t hash( const void *key, size_t length, const uint32_t initval);
++#ifdef USE_REPLICATION
++char *assoc_key_snap(int *n);
++#endif
--- patch-port-memcached.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081219174358.52B9317048>