From owner-cvs-all@FreeBSD.ORG Fri Feb 23 21:31:31 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EC15B16A404; Fri, 23 Feb 2007 21:31:31 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id D900413C4A8; Fri, 23 Feb 2007 21:31:31 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id B4DDC1A4D9A; Fri, 23 Feb 2007 13:31:31 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id B8C64514E7; Fri, 23 Feb 2007 16:31:30 -0500 (EST) Date: Fri, 23 Feb 2007 16:31:30 -0500 From: Kris Kennaway To: Brian Somers Message-ID: <20070223213130.GA89494@xor.obsecurity.org> References: <200702232023.l1NKNaeZ086158@repoman.freebsd.org> <20070223204112.GA88584@xor.obsecurity.org> <20070223131654.489d5ae6@conflict.ca.sophos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070223131654.489d5ae6@conflict.ca.sophos.com> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Brian Somers , cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_softdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2007 21:31:32 -0000 On Fri, Feb 23, 2007 at 01:16:54PM -0800, Brian Somers wrote: > On Fri, 23 Feb 2007 15:41:12 -0500 > Kris Kennaway wrote: > > > On Fri, Feb 23, 2007 at 08:23:36PM +0000, Brian Somers wrote: > > > brian 2007-02-23 20:23:36 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/ufs/ffs ffs_alloc.c ffs_softdep.c > > > Log: > > > Account for di_blocks allocations when IN_SPACECOUNTED is set in an > > > inode's i_flag. > > > > > > It's possible that after ufs_infactive() calls softdep_releasefile(), > > > i_nlink stays >0 for a considerable amount of time (> 60 seconds here). > > > During this period, any ffs allocation routines that alter di_blocks > > > must also account for the blocks in the filesystem's fs_pendingblocks > > > value. > > > > > > This change fixes an eventual df/du discrepency that will happen as > > > the result of fs_pendingblocks being reduced to <0. > > > > > > The only manifestation of this that people may recognise is the > > > following message on boot: > > > > > > /somefs: update error: blocks -N files M > > > > > > at which point the negative pending block count is adjusted to zero. > > > > \o/ I hate that bug! > > As do I! As a result of the bug, all Sophos mail appliance > customers had to suffer bi-weekly reboots for the past year > (well, it was hardly the fault of this bug initially!). > > It took weeks to fix -- I have never been able to reproduce > the problem on demand and had to resort to inserting copious > amounts of diagnostics on several machines then sitting around > 'till ffsinfo said one of the machines had "bitten". > > Until recently, even that strategy didn't work as our test > machines just wouldn't see the problem. We recently released > a less powerful version of the appliance, and only then did > we see the problem reasonably frequently (between 4 and 24 > hours usually). Wow, nice job :) Kris