From nobody Wed Jan 7 21:19:34 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dmgsd3149z6NKrQ for ; Wed, 07 Jan 2026 21:19:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dmgsc2rgxz3XhR for ; Wed, 07 Jan 2026 21:19:48 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-3e89d226c3aso2330063fac.2 for ; Wed, 07 Jan 2026 13:19:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767820787; x=1768425587; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rEhjz5b7MRJ/t5+vW36VR7zicYma/zcDBZICdSsgQYE=; b=rnFXQVD2pGNilv1LaIMywzNQfkvYLDfhGfO2uzAAg3/UCn1+bM7YVZyzCkfo5Rb9p8 BslLcm/jptGx21jqEvAF4Hp0ffZsIDlIyiESrYhLkaDJt1B3ufbq8qeF2AnY5SncrOTl M6RjQb+Dh1PikxpsnfEGSZBtbE2e6vS81xJFxpJM0osW7skKEEhRu+gwUcKs4G3lFiki fXBs57mcw4HQqJa1U8x8+BfMOLjJnkoN1Ra1405orpNnaOdBk4Jq9bE5LYUb/4L4Do4a c4icNTI+RF0SSMwAFXKrhxgQpVHKxZHmeTwUxIaottS/1yEcd7BtAqzev/Yq/7WFifj2 W9Nw== X-Forwarded-Encrypted: i=1; AJvYcCW2Pi/GWeD1vBmQh78X/F9jOQU57eiIrx8UuAuAkPMMhbkw7QwiPJfWlsDrPNF9zezX44lVYF82KGZ2tKrTREOKmM10@freebsd.org X-Gm-Message-State: AOJu0Yyaqe7yI6Frsx/2r3o0AeD/3F76kbulMJScKaxFDRRJkj3s14Kl 5wxzAKEcNQRoY/w+DVd/NSfBgd8FBzgPXFfpQwMxRvaD/DXFG0gD52vWinynkIJgWZrHqEkDcHN EwTvDq7tljgP4V2FFDqp1FIrYTAfWkTE= X-Gm-Gg: AY/fxX4jgq74KVfVppzHqKJEH8bYC8QNT7g3AOAmTFiN3LGw1+tDpxC+pQulPWuHAA8 Sy5ZstH/Yvi7wJQJ3DZQfuXdM8597OJfqewlVEaJHMtLe9AyimY/cSRpDgEOYj4+B4YQ/yPqDrt IjZGFxh9cAqn7qBpsH/M03Pg0g6KJuNDRkr4Awn8LAerwXqOUp7cTFDGiSatbR90W4Wp1sMWecq GmPtXkIRcD/+hIq8tOVIC+9mj/8/tNPap54hWfThSrijQBfVIY5JXuPSHvV5HLR1v1jZKZY1Q4k x2XSMAGvX3aX5vFfm+JimY89wkmsg10EEI2wQCgXnyp0xG/fcM6Z3K7amPA+ X-Google-Smtp-Source: AGHT+IEQOomZaDXiO5e8N39VDmReLQOrqyxhup8p7cAWWX8dWKvfOZ1N+JE8ZeIsj5GH6CjBmydeVRghAzO3X6ZAuNE= X-Received: by 2002:a05:6820:1517:b0:65f:1038:130e with SMTP id 006d021491bc7-65f5508d9b5mr1594367eaf.73.1767820786901; Wed, 07 Jan 2026 13:19:46 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <6958dd10.b4b9.2aebecda@gitrepo.freebsd.org> In-Reply-To: From: Ed Maste Date: Wed, 7 Jan 2026 16:19:34 -0500 X-Gm-Features: AQt7F2oTUSGfcgWPCH9oMk3shvys8sv8EWd_bITa-PGDQRtXbOkfPl67gVfvvE8 Message-ID: Subject: Re: git: 27894e20f140 - main - libgeom: Fix segfault in 32-on-64 case To: John Baldwin Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rg_rav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.81 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-0.94)[-0.944]; NEURAL_HAM_SHORT(-0.86)[-0.863]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RWL_MAILSPIKE_GOOD(-0.10)[209.85.160.46:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MIME_TRACE(0.00)[0:+]; FREEFALL_USER(0.00)[carpeddiem]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; MISSING_XM_UA(0.00)[]; FROM_HAS_DN(0.00)[]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.160.46:from]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4dmgsc2rgxz3XhR On Tue, 6 Jan 2026 at 09:37, John Baldwin wrote: > > Should we perhaps not use pointers to hold the cookies? This is going to truncate > in the lib32 case which will probably still work in practice as the low 32 bits of > kernel object addresses are probably unique, but isn't foolproof. Perhaps the cookie > values should be stored as either kvaddr_t values, or uintmax_t? I left a comment in the review that it would be good to at least have a comment in the code explaining the 32-bit truncation (that in practice they are probably unique).