From owner-freebsd-doc  Tue Nov  6  8:37:20 2001
Delivered-To: freebsd-doc@freebsd.org
Received: from mao.stokely.org (mao.stokely.org [65.84.64.228])
	by hub.freebsd.org (Postfix) with ESMTP
	id 44B0A37B418; Tue,  6 Nov 2001 08:36:00 -0800 (PST)
Received: by mao.stokely.org (Postfix, from userid 2074)
	id 71C814B65D; Tue,  6 Nov 2001 08:35:54 -0800 (PST)
Date: Tue, 6 Nov 2001 08:35:54 -0800
From: Murray Stokely <murray.stokely@windriver.com>
To: Peter Pentchev <roam@ringlet.net>
Cc: Murray Stokely <murray@FreeBSD.org>, doc@FreeBSD.org
Subject: Re: TIDYFLAGS fixes all around the tree
Message-ID: <20011106083554.W1818@windriver.com>
References: <20011105175820.D77919@straylight.oblivion.bg> <20011105124156.D10872@windriver.com> <20011106125323.E10023@straylight.oblivion.bg>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="0IvGJv3f9h+YhkrH"
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20011106125323.E10023@straylight.oblivion.bg>; from roam@ringlet.net on Tue, Nov 06, 2001 at 12:53:25PM +0200
X-GPG-Key-ID: 1024D/0E451F7D
X-GPG-Key-Fingerprint: E2CA 411D DD44 53FD BB4B  3CB5 B4D7 10A2 0E45 1F7D
Sender: owner-freebsd-doc@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-doc.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-doc>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-doc>
X-Loop: FreeBSD.org


--0IvGJv3f9h+YhkrH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Nov 06, 2001 at 12:53:25PM +0200, Peter Pentchev wrote:
> Okay, so I was working from an 8-9 hours' old tree.  Still, maybe
> I'm being dumb, but I do not really see the point of the fix you
> committed.  It definitely does not fix the problem I reported,
> as seen by:
>=20
> [roam@straylight:v4 ~/fbsd/r/doc/ru_RU.KOI8-R/articles/explaining-bsd]$ m=
ake -V TIDYFLAGS
> -latin1
>=20
> As you can see, still no -m :(

[amd] /usr/doc/ru_RU.KOI8-R/articles/explaining-bsd> make TIDYFLAGS=3D-lati=
n1
[ jade output snipped ]
/usr/local/bin/tidy -i -m -f /dev/null -latin1 article.html
Can't open "/export/home/murray/.tidyrc"
*** Error code 1 (ignored)

Seems to be working now. =20

TIDYFLAGS is the user settable variable for additional flags to tidy,
while 'TIDYOPTS' is the internal makefile variable for the complete
set of flags to tidy.

TIDYOPTS=3D <defaults> ${TIDYFLAGS}

> As I already said, I do not see the point of 'VAR?=3D blah ${VAR}'.

TIDY?=3D          ${PREFIX}/bin/tidy
TIDYOPTS?=3D      -i -m -f /dev/null ${TIDYFLAGS}

This is not a case of VAR?=3D blah ${VAR}.  It is a case of B?=3D bla ${A}

> This statement only ever changes the value of VAR if VAR *is not set*.
> In that case, ${VAR} is empty, and VAR is set to 'blah'.  If VAR is
> already set, then this statement will have absolutely no effect :)

  I agree.  If you find a case like that in our makefiles, please fix
it. ;)

    - Murray

--0IvGJv3f9h+YhkrH
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (SunOS)
Comment: For info see http://www.gnupg.org

iD8DBQE76BFptNcQog5FH30RAoRUAJ0WOS+GDc3PbxpriRL4osKXzzoShQCfXzAh
2cvgbQL68QUrfKEUWJKzmoY=
=zZ1K
-----END PGP SIGNATURE-----

--0IvGJv3f9h+YhkrH--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message