From owner-p4-projects@FreeBSD.ORG  Sat Aug  2 18:49:27 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E85711065678; Sat,  2 Aug 2008 18:49:26 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A94F31065672;
	Sat,  2 Aug 2008 18:49:26 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (kientzle.com [66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 82B688FC13;
	Sat,  2 Aug 2008 18:49:26 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.129] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id m72InQtv015333;
	Sat, 2 Aug 2008 11:49:26 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <4894AC63.8070403@freebsd.org>
Date: Sat, 02 Aug 2008 11:50:11 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Anselm Strauss <strauss@freebsd.org>
References: <200807311508.m6VF8QUD097494@repoman.freebsd.org>
In-Reply-To: <200807311508.m6VF8QUD097494@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 146324 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Aug 2008 18:49:27 -0000

Anselm Strauss wrote:
> http://perforce.freebsd.org/chv.cgi?CH=146324

>  	ret = (a->compressor.write)(a, &h, sizeof(h));
> -	if (ret != ARCHIVE_OK) return (ARCHIVE_FATAL);
> +	if (ret != ARCHIVE_OK) {
> +		archive_set_error(&a->archive, EIO, "Can't write local file header");
> +		return (ARCHIVE_FATAL);
> +	}

compressor.write should have already set an error
code and message if it's returning an error.
So this isn't needed.  (In fact, it's a bad
idea.  The writer knows more about the cause
of the error, and by overwriting the error message,
you're just losing useful information.  It's
much more useful, for example, to see "Disk full"
or "read-only filesystem" than to see "can't
write Zip header.")