From owner-freebsd-current@FreeBSD.ORG Fri May 29 17:33:00 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from miki (localhost [IPv6:::1]) by hub.freebsd.org (Postfix) with SMTP id 6773A106567A; Fri, 29 May 2009 17:32:57 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Date: Sat, 30 May 2009 01:32:53 +0800 From: Ariff Abdullah To: Andriy Gapon Message-Id: <20090530013253.6a7517e7.ariff@FreeBSD.org> In-Reply-To: <4A1FEE04.1060202@freebsd.org> References: <4A1FEE04.1060202@freebsd.org> Organization: FreeBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Sat__30_May_2009_01_32_53_+0800_Ds3zXcOFY8/nr+e9" Cc: rpaulo@freebsd.org, rnoland@freebsd.org, ariff@freebsd.org, freebsd-current@freebsd.org, sam@freebsd.org, imp@freebsd.org Subject: Re: fixing kobj signatures X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 17:33:00 -0000 --Signature=_Sat__30_May_2009_01_32_53_+0800_Ds3zXcOFY8/nr+e9 Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 29 May 2009 17:15:32 +0300 Andriy Gapon wrote: >=20 > I think I have completed fixing signatures of kobj method > implementations in the whole head tree. > The current diff here: > http://people.freebsd.org/~avg/ >=20 > It is quite arbitrarily split into the following files: > kobj-agp.diff > kobj-arm.diff > kobj-linker.diff > kobj-other.diff > kobj-sound.diff >=20 > Most of the changes are quite trivial but not all. >=20 > o kobj-linker.diff - I am not sure if changing interface signature > was a good idea. >=20 > o kobj-sound.diff - this is a slightly updated version of the patch > previously posted to multimedia ml; > Ariff, could you please let me know about your plans with respect to > 8.0 release? >=20 I'm actually in the middle of discussion with joel@ to wrap things up in order to get everything under my sleeves into tree before freeze Your diff looks simmilar to what I intended to commit as a whole, so I guess I'm ok with it. Except that, let me deal with it within next week unless I'm wrong about June 25th. > o kobj-arm.diff - it seems that npe_miibus_writereg in > sys/arm/xscale/ixp425/if_npe.c) could now make use of non-void > return type to properly report errors (XXX cases). But I am not sure > if it is actually checked in the calling code (otherwise how does it > work now?). Maybe there are more places like that. >=20 > Please review the patch. I might have done something wrong, made > some obvious mistake (like typo) or missed an opportunity to improve > the code beyond mechanical changes. >=20 > I tested the patch by enabling 'notyet' definition of KOBJMETHOD in > kobj.h and building the following: all arm kernels (without > modules), GENERIC kernels for all archs that have them (with > modules), LINT kernels for all archs that have them (without > modules). >=20 > It is quite possible, of course, that some incorrect signatures were > not found using the above build. For instance, in the code under > some non-default option. But I think the number of such functions > should be quite small and they should be trivial to fix later. >=20 > I propose this patch for inclusion into the three before 8.0 freeze > depending on response from Ariff. > if this patch is not committed before 8.0 freeze (whole or any > significant portion of the patch), then I'd like to request a branch > under users/ where I could integrate this patch for future merging. > -- Ariff Abdullah FreeBSD ... Recording in stereo is obviously too advanced and confusing for us idiot ***** users :P ........ ... Going with the standard and orthodox is the death of intellect .............. --Signature=_Sat__30_May_2009_01_32_53_+0800_Ds3zXcOFY8/nr+e9 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkogHEUACgkQlr+deMUwTNoRugCdFiUElIy+P6NIvzjRfuEQekPw LK0AoJSNM/RBjXd2K51+mlqMoBlSOm+l =QJrK -----END PGP SIGNATURE----- --Signature=_Sat__30_May_2009_01_32_53_+0800_Ds3zXcOFY8/nr+e9--