From owner-freebsd-current Tue Oct 21 22:37:58 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id WAA07126 for current-outgoing; Tue, 21 Oct 1997 22:37:58 -0700 (PDT) (envelope-from owner-freebsd-current) Received: from mexico.brainstorm.eu.org (root@mexico.brainstorm.fr [193.56.58.253]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id WAA07121 for ; Tue, 21 Oct 1997 22:37:56 -0700 (PDT) (envelope-from roberto@keltia.freenix.fr) Received: from brasil.brainstorm.eu.org (brasil.brainstorm.fr [193.56.58.33]) by mexico.brainstorm.eu.org (8.8.4/8.8.4) with ESMTP id HAA01435 for ; Wed, 22 Oct 1997 07:38:08 +0200 Received: (from uucp@localhost) by brasil.brainstorm.eu.org (8.8.6/brasil-1.2) with UUCP id HAA23967 for current@FreeBSD.ORG; Wed, 22 Oct 1997 07:37:44 +0200 Received: (from roberto@localhost) by keltia.freenix.fr (8.8.7/keltia-2.11/nospam) id HAA03509; Wed, 22 Oct 1997 07:28:19 +0200 (CEST) (envelope-from roberto) Message-ID: <19971022072818.27417@keltia.freenix.fr> Date: Wed, 22 Oct 1997 07:28:18 +0200 From: Ollivier Robert To: current@FreeBSD.ORG Subject: Re: nullfs & current UPDATE! References: <199710220240.MAA23169@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.84 In-Reply-To: <199710220240.MAA23169@godzilla.zeta.org.au>; from Bruce Evans on Wed, Oct 22, 1997 at 12:40:50PM +1000 X-Operating-System: FreeBSD 3.0-CURRENT ctm#3745 AMD-K6 MMX @ 208 MHz Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk According to Bruce Evans: > style.9 says not to obfuscate code by initializes variables in declarations. I tried to be consistent with the code around in null_vnops.c... Do you think we should change both miscfs/nullfs and miscfs/umapfs to conform to style(9) ? The code has been like this since 4.4BSD-lite... > It doesn't do nothing, especially now. I changed the comment in the commit although I could make it clearer. > It is an obfuscation to set ap->a_vp = vp above and then not use it here. > I think the function is still simple enough for it to be clearer without > temporary variables. `lowervp' can be written fairly concisely as > VTONULL(ap->a_vp)->null_lowervp. In fact, there is already a macro > NULLVPTOLOWERVP() for this. It seems to be used consistently to set > `lowervp' variables that are passed to other functions and not used again, > as lowervp is here. It is not used consistly in nullfs :-( -- Ollivier ROBERT -=- FreeBSD: There are no limits -=- roberto@keltia.freenix.fr FreeBSD keltia.freenix.fr 3.0-CURRENT #41: Sat Oct 18 18:47:01 CEST 1997