From owner-svn-src-all@FreeBSD.ORG  Fri Dec  3 16:38:15 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 3798A1065672;
	Fri,  3 Dec 2010 16:38:15 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Brooks Davis <brooks@freebsd.org>
Date: Fri, 3 Dec 2010 11:37:55 -0500
User-Agent: KMail/1.6.2
References: <201012010324.oB13OdL8060240@svn.freebsd.org>
	<1291295967.58583.59.camel@buffy.york.ac.uk>
	<20101203151343.GA7429@lor.one-eyed-alien.net>
In-Reply-To: <20101203151343.GA7429@lor.one-eyed-alien.net>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201012031138.08347.jkim@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	Gavin Atkinson <gavin@freebsd.org>,
	Weongyo Jeong <weongyo@freebsd.org>, src-committers@freebsd.org
Subject: Re: svn commit: r216089 - head/sbin/ifconfig
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Dec 2010 16:38:15 -0000

On Friday 03 December 2010 10:13 am, Brooks Davis wrote:
> On Thu, Dec 02, 2010 at 01:19:27PM +0000, Gavin Atkinson wrote:
> > On Wed, 2010-12-01 at 03:24 +0000, Weongyo Jeong wrote:
> > > Author: weongyo
> > > Date: Wed Dec  1 03:24:38 2010
> > > New Revision: 216089
> > > URL: http://svn.freebsd.org/changeset/base/216089
> > >
> > > Log:
> > >   Don't print usbus[0-9] interfaces that it's not the
> > > interesting interface type for ifconfig(8).
> > >
> > > Modified:
> > >   head/sbin/ifconfig/ifconfig.c
> > >
> > > Modified: head/sbin/ifconfig/ifconfig.c
> > > ===============================================================
> > >=============== --- head/sbin/ifconfig/ifconfig.c	Tue Nov 30
> > > 22:39:46 2010	(r216088) +++ head/sbin/ifconfig/ifconfig.c	Wed
> > > Dec  1 03:24:38 2010	(r216089) @@ -295,6 +295,8 @@ main(int
> > > argc, char *argv[])
> > >  			sdl = (const struct sockaddr_dl *) ifa->ifa_addr;
> > >  		else
> > >  			sdl = NULL;
> > > +		if (sdl != NULL && sdl->sdl_type == IFT_USB)
> > > +			continue;
> > >  		if (cp != NULL && strcmp(cp, ifa->ifa_name) == 0 &&
> > > !namesonly) continue;
> > >  		iflen = strlcpy(name, ifa->ifa_name, sizeof(name));
> >
> > I may be misunderstanding, but isn't this more of a hack than the
> > correct solution?  I appreciate that there are a large number of
> > defined interface types, but I wonder if we should instead check
> > for interface types we are prepared to accept, rather than
> > skipping ones we know we don't want?
> >
> > Was this issue introduced with the introduction of the USB pcap
> > changes?
>
> We might consider an interface flag for interfaces that aren't
> configurable in a meaninful way by ifconfig.  Then ifconfig
> wouldn't have to change going forward.

+1

Jung-uk Kim