From owner-cvs-all  Mon Jun 21 13:18:23 1999
Delivered-To: cvs-all@freebsd.org
Received: from gvr.gvr.org (gvr.gvr.org [194.151.74.97])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6E95B14C85; Mon, 21 Jun 1999 13:18:18 -0700 (PDT)
	(envelope-from guido@gvr.org)
Received: by gvr.gvr.org (Postfix, from userid 657)
	id 3C6C65ABE; Mon, 21 Jun 1999 22:18:17 +0200 (MET DST)
Message-ID: <19990621221816.A28898@gvr.org>
Date: Mon, 21 Jun 1999 22:18:16 +0200
From: Guido van Rooij <guido@gvr.org>
To: Doug Rabson <dfr@nlsystems.com>,
	Peter Wemm <peter@netplex.com.au>
Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/isa sio.c
References: <19990621071211.988BB75@overcee.netplex.com.au> <Pine.BSF.4.05.9906211035360.80685-100000@herring.nlsystems.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.93.2i
In-Reply-To: <Pine.BSF.4.05.9906211035360.80685-100000@herring.nlsystems.com>; from Doug Rabson on Mon, Jun 21, 1999 at 10:37:27AM +0100
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

On Mon, Jun 21, 1999 at 10:37:27AM +0100, Doug Rabson wrote:
> 
> I would rather that people tackle these weaknesses by asking me how to
> solve their problem or by suggesting new functionality for the 'approved'
> api. I really think its a bad idea for drivers to use bus_private.h at
> all.

You could actually even enforce this with some #define/#ifdef combination.
(#define MAY_USE_INCLUDE_FILE in file.c
#ifndef MAY_USE_INCLUDE_FILE
	#error Do not use this include file
#endif

At least occasional errors like the one in sio.c can be prevented.

-Guido


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message