From owner-freebsd-arch Sat Feb 16 23: 0:14 2002 Delivered-To: freebsd-arch@freebsd.org Received: from rwcrmhc54.attbi.com (rwcrmhc54.attbi.com [216.148.227.87]) by hub.freebsd.org (Postfix) with ESMTP id BAF0137B404; Sat, 16 Feb 2002 23:00:10 -0800 (PST) Received: from InterJet.elischer.org ([12.232.206.8]) by rwcrmhc54.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020217070010.WCPO1214.rwcrmhc54.attbi.com@InterJet.elischer.org>; Sun, 17 Feb 2002 07:00:10 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id WAA44493; Sat, 16 Feb 2002 22:54:52 -0800 (PST) Message-Id: <200202170654.WAA44493@InterJet.elischer.org> Date: Sat, 16 Feb 2002 22:54:51 -0800 (PST) From: Julian Elischer To: Matthew Dillon Cc: Alfred Perlstein , Poul-Henning Kamp , arch@FreeBSD.ORG, jhb@FreeBSD.ORG, peter@wemm.org, jake@locore.ca Subject: Re: gettimeofday() and crhold()/crfree() (was Re: gettimeofday() Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG and copyout(). Is copyout() MPSAFE on non-i386 archs? ) In-Reply-To: <200202170641.g1H6fRb43456@apollo.backplane.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Sat, 16 Feb 2002, Matthew Dillon wrote: > > :the whole point is moot.. > :you don't need to get or drop the creds at all.. > : > :see the attached patch I'm about to commit a version of.. > > I like it in general, but I don't like INVARIANTS causing so much grief > in the SMP path. If the whole point is to not drop the ucred in the > syscall then we shouldn't drop it whether INVARIANTS is set or not. > I would like to see the invariants sections simply removed. > > I like to run with INVARIANTS set, even on production systems, because > I like the extra assertions it makes. I agree but jhb wants to have it that way... He wants to be able to catch anyone accessing the ucred of a thread that is in user space. I personally think we should just remove the code. > > In anycase, I am going to go ahead and commit the mutex pool part of > my patch to cut down on the size of the ucred structure. Then I'm going > to go through and see if we do any other messing around with credentials > (like in the NFS code) to determine if removing Giant is still necessary. > > -Matt > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message