From owner-freebsd-stable Sun Mar 24 18: 3:27 2002 Delivered-To: freebsd-stable@freebsd.org Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38]) by hub.freebsd.org (Postfix) with ESMTP id 3A69A37B400 for ; Sun, 24 Mar 2002 18:03:22 -0800 (PST) Received: from blossom.cjclark.org ([12.234.91.48]) by rwcrmhc51.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020325020321.VEFK2626.rwcrmhc51.attbi.com@blossom.cjclark.org>; Mon, 25 Mar 2002 02:03:21 +0000 Received: (from cjc@localhost) by blossom.cjclark.org (8.11.6/8.11.6) id g2P23Lp83249; Sun, 24 Mar 2002 18:03:21 -0800 (PST) (envelope-from cjc) Date: Sun, 24 Mar 2002 18:03:21 -0800 From: "Crist J. Clark" To: Ryan Davis Cc: Randy Bush , Dima Dorfman , FreeBSD Stable Subject: Re: mergemaster mtree:No such file or directory Message-ID: <20020324180321.D82944@blossom.cjclark.org> Reply-To: cjclark@alum.mit.edu References: <6E639CB8-3F7E-11D6-B638-0030655293B0@zenspider.com> <20020324154542.B82432@blossom.cjclark.org> <20020324163351.A73171@greed.zenspider.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020324163351.A73171@greed.zenspider.com>; from ryand-freebsd@ZenSpider.com on Sun, Mar 24, 2002 at 04:33:51PM -0800 X-URL: http://people.freebsd.org/~cjc/ Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 24, 2002 at 04:33:51PM -0800, Ryan Davis wrote: > On 2002-03-24T15:45:42, Crist J. Clark wrote: > > > > Shouldn't the build system (including mergemaster) be impervious to > > > side-effects from things like PATH? > > > > I could easily envision situations where one might want to play games > > with one's PATH when using mergemaster(8). I think having > > mergemaster(8) toss aside the user's PATH and essentially hardcode its > > own makes the tool much less flexible, violates POLA, and generally > > violates the whole purpose of PATH and environmental variables. > > Call me wacky, but "play games when using mergemaster" == command line > option in my book. Good Configuration Management would probably state > that the build and configuration tools should do the same thing every > time regardless of how wonky my environment is. No way. Take the MAKEOBJDIRPREFIX environmental variable. People change this all of the time. You would hear much screaming if you decided that people couldn't customize their builds. If you have a wonky environment it is either because (a) you know what you are doing and you want it that way or (b) you don't know what you are doing and may have a broken environment. For people in (a), they want the tools to do what they are told to do. They don't want to have to hack the mergemaster(8) script or bsd.*.mk files in order for them to behave as they want. People in group (b) should fix their environments. If they need help, there's -questions. Anyway, does this really have anything to do with the original question? Now that I actually look at mergemaster(8), #!/bin/sh # mergemaster # Compare files created by /usr/src/etc/Makefile (or the directory # the user specifies) with the currently installed copies. # Copyright 1998-2001 Douglas Barton # DougB@FreeBSD.org # $FreeBSD: src/usr.sbin/mergemaster/mergemaster.sh,v 1.6.2.9 2001/08/11 20:27:52 dougb Exp $ PATH=/bin:/usr/bin:/usr/sbin It does, and has always, clobbered PATH. (Hmm... I guess I musta had to hack that line in the past. Coulda sworn I did it from the command line.) -- Crist J. Clark | cjclark@alum.mit.edu | cjclark@jhu.edu http://people.freebsd.org/~cjc/ | cjc@freebsd.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message