From owner-dev-commits-src-all@freebsd.org  Thu Aug 12 15:20:53 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id D2C5266DD79;
 Thu, 12 Aug 2021 15:20:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4Glr455gtsz4vDX;
 Thu, 12 Aug 2021 15:20:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx
 [66.234.199.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 234D725085;
 Thu, 12 Aug 2021 15:20:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: f4c6843ec2b9 - main - xen: use correct cache attributes for
 Xen specific memory regions
To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <royger@FreeBSD.org>,
 src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
 dev-commits-src-main@FreeBSD.org
References: <202108120724.17C7OJ8h043708@gitrepo.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <d1f8a587-5b7f-91bd-3daf-eba1a1c77bab@FreeBSD.org>
Date: Thu, 12 Aug 2021 08:20:51 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <202108120724.17C7OJ8h043708@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Aug 2021 15:20:53 -0000

On 8/12/21 12:24 AM, Roger Pau Monné wrote:
> The branch main has been updated by royger:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=f4c6843ec2b9aa5eff475778fb000ed6278c5b77
> 
> commit f4c6843ec2b9aa5eff475778fb000ed6278c5b77
> Author:     Roger Pau Monné <royger@FreeBSD.org>
> AuthorDate: 2021-04-09 09:31:44 +0000
> Commit:     Roger Pau Monné <royger@FreeBSD.org>
> CommitDate: 2021-08-12 07:18:32 +0000
> 
>      xen: use correct cache attributes for Xen specific memory regions
>      
>      bus_activate_resource maps memory regions as uncacheable on x86, which
>      is more strict than required for regions allocated using xenmem_alloc,
>      so don't rely on bus_activate_resource and instead map the region
>      using pmap_mapdev_attr and VM_MEMATTR_XEN as the cache attribute.
>      
>      Sponsored by: Citrix Systems R&D

It would probably be cleaner to use bus_map_resource() for this instead.  It
would mean you would have to use a structure that writes to as the argument
to bus_read/write_* instead of using the resource directly.

-- 
John Baldwin