From owner-freebsd-usb@FreeBSD.ORG  Mon Sep 21 22:38:47 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6EB9106566B
	for <freebsd-usb@freebsd.org>; Mon, 21 Sep 2009 22:38:47 +0000 (UTC)
	(envelope-from tlb@tlb.org)
Received: from anybots.com (mail.anybots.com [64.142.12.96])
	by mx1.freebsd.org (Postfix) with SMTP id B23AE8FC14
	for <freebsd-usb@freebsd.org>; Mon, 21 Sep 2009 22:38:47 +0000 (UTC)
Received: (qmail 51216 invoked from network); 21 Sep 2009 22:38:47 -0000
Received: from unknown (HELO ?10.10.10.66?) (10.10.10.66)
	by 10.10.10.20 with SMTP; 21 Sep 2009 22:38:47 -0000
Message-Id: <2C0D6269-1296-4D34-8029-828A0FE281CB@tlb.org>
From: Trevor Blackwell <tlb@tlb.org>
To: freebsd-usb@freebsd.org
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v935.3)
Date: Mon, 21 Sep 2009 15:38:46 -0700
X-Mailer: Apple Mail (2.935.3)
Subject: libusb20 api
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Sep 2009 22:38:48 -0000


This always fails:

       char devname[256];
       if (libusb20_dev_get_iface_desc(pdev, n, devname,  
sizeof(devname))) break;

while this works:

       char devname[128];
       if (libusb20_dev_get_iface_desc(pdev, n, devname,  
sizeof(devname))) break;

Because this function takes a uint8_t for length:

<libusb20_ugen20.c:851>:
static int
ugen20_dev_get_iface_desc(struct libusb20_device *pdev,
     uint8_t iface_index, char *buf, uint8_t len)

even though the kernel ioctl structure has a 16-bit length.

Hans, why not just use size_t for such arguments?

--
Trevor Blackwell		650 776 7870	tlb@tlb.org