From nobody Fri May 3 15:24:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VWF2r5SgYz5KC0l; Fri, 3 May 2024 15:24:20 +0000 (UTC) (envelope-from SRS0=a8w7=MG=klop.ws=ronald-lists@realworks.nl) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [194.109.157.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VWF2r4dmVz559l; Fri, 3 May 2024 15:24:20 +0000 (UTC) (envelope-from SRS0=a8w7=MG=klop.ws=ronald-lists@realworks.nl) Authentication-Results: mx1.freebsd.org; none Date: Fri, 3 May 2024 17:24:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1714749859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JrKXaZJ0TPbJmFsLimpMgTh1GbuEBlDr2i3HmBtzLs8=; b=RiHakGH83MCJtoIDQm+AtaKQz5RoYPT3E8dm3R2ZNESQVWPYm4j+FbeV0uXYmnrLCfw3zL j+0295dPA4qSc+3S98rGAI8z7AF9XSZhcNQjk9arFGThdzpyklYHqjek686Nu7S5oHenDq 2esQRrGLIebEjcWa27dnX5zgX/bwLx6JAUQl9HURDnSC7253L5rJxgtqVH0Fb4s6Q61FyQ ekC9VkGnzLEU8TRK5Dktd4o+Nllhu+wSPp3NRWqEJSzO07DGeuQB1SdT4i/CSAQsGhw1oA Wkz92hylQBEdzF6U4CuHz1HEPAEI7uti1DWfzKjmaZjjUt8HSVO33jIc7ycEjA== From: Ronald Klop To: Ronald Klop Cc: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, Warner Losh , dev-commits-src-main@FreeBSD.org Message-ID: <304810585.11110.1714749859580@localhost> In-Reply-To: <1010899452.10421.1714749653185@localhost> References: <202405031447.443ElgZj051266@gitrepo.freebsd.org> <1010899452.10421.1714749653185@localhost> Subject: Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_11109_906100372.1714749859553" X-Mailer: Realworks (701.18) Importance: Normal X-Priority: 3 (Normal) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL] X-Rspamd-Queue-Id: 4VWF2r4dmVz559l ------=_Part_11109_906100372.1714749859553 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Ah. Found https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277673 in your next commit. Cheers, Ronald. Van: Ronald Klop Datum: vrijdag, 3 mei 2024 17:20 Aan: Warner Losh CC: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org Onderwerp: Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM > > Are you sure you used the right PR? > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277637 > "[NEW PORT] security/enc: Modern and friendly CLI alternative to GnuPG" > > > Regards, > Ronald. > > > Van: Warner Losh > Datum: vrijdag, 3 mei 2024 16:47 > Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org > Onderwerp: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM >> >> The branch main has been updated by imp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=12117d0e9314d1706508386c1c49ace2de578b31 >> >> commit 12117d0e9314d1706508386c1c49ace2de578b31 >> Author: Matthew Grooms >> AuthorDate: 2024-05-03 14:41:05 +0000 >> Commit: Warner Losh >> CommitDate: 2024-05-03 14:46:59 +0000 >> >> da: Update trim stats for WRITE SAME and ATA TRIM >> >> The scsi UNMAP path updated trim stats in the da sysctl, but the ATA >> TRIM passthru and WRITE SAME paths did not. Add code so they do. >> >> PR: 277637 >> Reviewed by: imp (tweaked WS path to update ranges) >> --- >> sys/cam/scsi/scsi_da.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c >> index 9b3d706d6168..0daaff9229b0 100644 >> --- a/sys/cam/scsi/scsi_da.c >> +++ b/sys/cam/scsi/scsi_da.c >> @@ -4208,6 +4208,9 @@ da_delete_trim(struct cam_periph *periph, union ccb *ccb, struct bio *bp) >> da_default_timeout * 1000); >> ccb->ccb_h.ccb_state = DA_CCB_DELETE; >> ccb->ccb_h.flags |= CAM_UNLOCKED; >> + softc->trim_count++; >> + softc->trim_ranges += ranges; >> + softc->trim_lbas += block_count; >> cam_iosched_submit_trim(softc->cam_iosched); >> } >> >> @@ -4268,6 +4271,9 @@ da_delete_ws(struct cam_periph *periph, union ccb *ccb, struct bio *bp) >> da_default_timeout * 1000); >> ccb->ccb_h.ccb_state = DA_CCB_DELETE; >> ccb->ccb_h.flags |= CAM_UNLOCKED; >> + softc->trim_count++; >> + softc->trim_ranges++; >> + softc->trim_lbas += count; >> cam_iosched_submit_trim(softc->cam_iosched); >> } >> >> >> >> >> > > ------=_Part_11109_906100372.1714749859553 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit Ah.

Found https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277673 in your next commit.

Cheers,
Ronald.

 

Van: Ronald Klop <ronald-lists@klop.ws>
Datum: vrijdag, 3 mei 2024 17:20
Aan: Warner Losh <imp@FreeBSD.org>
CC: dev-commits-src-all@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Onderwerp: Re: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM

Are you sure you used the right PR?

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277637
"[NEW PORT] security/enc: Modern and friendly CLI alternative to GnuPG"


Regards,
Ronald.

 

Van: Warner Losh <imp@FreeBSD.org>
Datum: vrijdag, 3 mei 2024 16:47
Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Onderwerp: git: 12117d0e9314 - main - da: Update trim stats for WRITE SAME and ATA TRIM

The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=12117d0e9314d1706508386c1c49ace2de578b31

commit 12117d0e9314d1706508386c1c49ace2de578b31
Author:     Matthew Grooms <mgrooms@shrew.net>
AuthorDate: 2024-05-03 14:41:05 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-05-03 14:46:59 +0000

    da: Update trim stats for WRITE SAME and ATA TRIM
    
    The scsi UNMAP path updated trim stats in the da sysctl, but the ATA
    TRIM passthru and WRITE SAME paths did not. Add code so they do.
    
    PR: 277637
    Reviewed by: imp (tweaked WS path to update ranges)
---
 sys/cam/scsi/scsi_da.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
index 9b3d706d6168..0daaff9229b0 100644
--- a/sys/cam/scsi/scsi_da.c
+++ b/sys/cam/scsi/scsi_da.c
@@ -4208,6 +4208,9 @@ da_delete_trim(struct cam_periph *periph, union ccb *ccb, struct bio *bp)
              da_default_timeout * 1000);
    ccb->ccb_h.ccb_state = DA_CCB_DELETE;
    ccb->ccb_h.flags |= CAM_UNLOCKED;
+   softc->trim_count++;
+   softc->trim_ranges += ranges;
+   softc->trim_lbas += block_count;
    cam_iosched_submit_trim(softc->cam_iosched);
 }
 
@@ -4268,6 +4271,9 @@ da_delete_ws(struct cam_periph *periph, union ccb *ccb, struct bio *bp)
            da_default_timeout * 1000);
    ccb->ccb_h.ccb_state = DA_CCB_DELETE;
    ccb->ccb_h.flags |= CAM_UNLOCKED;
+   softc->trim_count++;
+   softc->trim_ranges++;
+   softc->trim_lbas += count;
    cam_iosched_submit_trim(softc->cam_iosched);
 }
 
 

 

  ------=_Part_11109_906100372.1714749859553--