From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 26 11:00:21 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5EA99106566C for ; Wed, 26 Oct 2011 11:00:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 12E028FC12 for ; Wed, 26 Oct 2011 11:00:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9QB0Khd066610 for ; Wed, 26 Oct 2011 11:00:20 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9QB0K2X066609; Wed, 26 Oct 2011 11:00:20 GMT (envelope-from gnats) Resent-Date: Wed, 26 Oct 2011 11:00:20 GMT Resent-Message-Id: <201110261100.p9QB0K2X066609@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Hooman Fazaeli Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ADF04106564A for ; Wed, 26 Oct 2011 10:58:21 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 9E49A8FC08 for ; Wed, 26 Oct 2011 10:58:21 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9QAwL6V038811 for ; Wed, 26 Oct 2011 10:58:21 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p9QAwL5v038810; Wed, 26 Oct 2011 10:58:21 GMT (envelope-from nobody) Message-Id: <201110261058.p9QAwL5v038810@red.freebsd.org> Date: Wed, 26 Oct 2011 10:58:21 GMT From: Hooman Fazaeli To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/162028: misplaced #endif in ixgbe.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2011 11:00:21 -0000 >Number: 162028 >Category: kern >Synopsis: misplaced #endif in ixgbe.c >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 26 11:00:20 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Hooman Fazaeli >Release: 7.4-RELEASE >Organization: Sepehr S. T. Co. Ltd. >Environment: FreeBSD HP04 7.4-RELEASE FreeBSD 7.4-RELEASE #1: Thu May 12 02:24:45 IRDT 2011 admin@:/usr/src/sys/i386/compile/SERVER74-001 i386 >Description: A misplaced #endif in ixgbe_ioctl() causes interface MTU to become zero when INET and INET6 are undefined. >How-To-Repeat: See sys/dev/ixgbe/ixgbe.c v 1.53 function ixgbe_ioctl. >Fix: Patch attached with submission follows: --- ixgbe.c.orig 2011-10-17 20:37:17.000000000 +0330 +++ ixgbe.c 2011-10-17 20:38:40.000000000 +0330 @@ -898,8 +898,8 @@ arp_ifinit(ifp, ifa); } else error = ether_ioctl(ifp, command, data); - break; #endif + break; case SIOCSIFMTU: IOCTL_DEBUGOUT("ioctl: SIOCSIFMTU (Set Interface MTU)"); if (ifr->ifr_mtu > IXGBE_MAX_FRAME_SIZE - ETHER_HDR_LEN) { >Release-Note: >Audit-Trail: >Unformatted: