From owner-dev-commits-src-all@freebsd.org Wed Mar 3 15:38:17 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74C6056E240 for ; Wed, 3 Mar 2021 15:38:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DrJ6x2fxqz3w6N for ; Wed, 3 Mar 2021 15:38:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72b.google.com with SMTP id a9so9789453qkn.13 for ; Wed, 03 Mar 2021 07:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OfxdMQ9K83s8cNZVwv5YEIuT/l5+sxRoQu4abRvbDN8=; b=VVzxaJrpqYwD7a1PZv8Y5OD/cdteNwhGhn9qoxj4Mbzmi8MP9mI3n5KCfmiFw9PnXO 9YSA8vlt7ZUb6314JAMYmD32rnn1YhOo+IDb5AyxXIIiAiDmvrtPoeAsum0yuy0z6Wh8 uh3pJ8bZhtGd2qLomuQNocWToH3tRhcZftnGsiXtrdcnRBhveZvsUKfOh8SJP7rGy0MX 8lCACyXIJTwmpFLs0y9gu20c93Ty58tUVvzJmptInu6tZBzdZ5yIVSO3Ibil4YnmytCv ZUav1mSVP6mLkkx+RG/HId0FQfodreFPVQI2LAvRD5XXUX/P1qpq115wI5OT1hoSZM7t YNoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OfxdMQ9K83s8cNZVwv5YEIuT/l5+sxRoQu4abRvbDN8=; b=WP30lDGBhYJCmJzGZ/IRbVhMYtL/qgZFzP3Jqmje70FghSstMOuYRlduff7ecXzAna TtbwM89UqYkFxgL6sxil0FdIPueeUL5UJ3dyBfq+vaJbIZVQuxyeLIl1tairqsf75nva IWVy1/RAAl89vFmRPob67W3lNHeZPXF3q4x+7hS2qgywZE6CR6iKbXnEwu7iG0yGEE4q ALm2NIXoL/bdFWKwqGPFIsGdImfPBarawpVQkLpgV5Gd5OyXGEIyahtudAmqMzX3RuH4 mqNc1ao3oOKpftXQXQejMqVrZUZMgiZWFPsZvussi/bsqENONRqFz+1P+gQ3oXHgI4dX MPTA== X-Gm-Message-State: AOAM531Vh4GsnW9vtqdlB1al9oLSJ7dvc1wXR5qa01Xf8cQVJ75F1Il4 7kfECKVfeyDwlVZZW4InAcMi6P3d5c9i/Bgej+nCyQ== X-Google-Smtp-Source: ABdhPJzD1lSds62JoJ+5+KMA+f2UsILHA7iEIVuSx72dqWsdzrJfZvsgxO7gBcqOO1AFhSzJPhfuATTepPSs2KwqVrg= X-Received: by 2002:a37:6cc6:: with SMTP id h189mr25891589qkc.195.1614785896534; Wed, 03 Mar 2021 07:38:16 -0800 (PST) MIME-Version: 1.0 References: <202103031253.123CrxKG051357@gndrsh.dnsmgr.net> <14d09680-1036-4a7e-8a0e-c3063cac8bc9@www.fastmail.com> In-Reply-To: From: Warner Losh Date: Wed, 3 Mar 2021 08:38:05 -0700 Message-ID: Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. To: Nathan Whitehorn Cc: Brandon Bergren , "Rodney W. Grimes" , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DrJ6x2fxqz3w6N X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 15:38:17 -0000 On Wed, Mar 3, 2021 at 7:13 AM Nathan Whitehorn wrote: > > > On 3/3/21 9:05 AM, Brandon Bergren wrote: > > On Wed, Mar 3, 2021, at 6:53 AM, Rodney W. Grimes wrote: > >> What am I missing here? One place I am being told this is run in > >> an environment that may not even be an EFI booted system, and in > >> another place it is being used as a test if something is mounted > >> on it, which should only be true on an EFI booted system. > > That the script in question is a generic script that runs as part of > bsdinstall on every platform and has to be universal. > > > > The actual *problem* here is that usr.sbin/bsdinstall/scripts/bootconfig > has a default case that is > > *) die "Unsupported arch $(uname -m) for UEFI > install" > > > > which then causes the main script to bail out, leaving the system in a > half-installed state. > > > > If that had just been an exit 0 this would have never been a problem, I > suppose. > > > > Before the original change that broke this, there was a check that the > script was not running on powerpc or mips platforms before running the efi > bits, but this got taken out. > > > > Well, incidentally. The bootconfig script needs to know if there is an > ESP it should configure, but the signalling mechanism (the presence of > the ESP mount point) was being broken by mtree making that directory > unconditionally even on systems that don't use EFI. So then bootconfig > tried to set it up, but failed later on, because there was no EFI loader > to set up. The mtree change makes the ESP mount point only exist on > systems with an ESP. > So you made a unilateral change, without discussion of the bigger design, to something without even asking the original person who made the change to mtree about it for what sounds like an obscure case in the installer that could be solved in a different way? It's trivial enough to look at the boot method sysctl and skip the EFI update if we didn't boot EFI (and if by change that's not on all systems, it's easy enough to add it on all systems). I have no notion about why that wasn't considered, at least, before jumping in and taking people by surprise. Next time, talk to people first. That's the whole point of having review tools, mailing list and git blame. Warner