From nobody Mon Jul 24 11:06:54 2023
X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R8cnF2Fx7z4pTVQ;
	Mon, 24 Jul 2023 11:07:13 +0000 (UTC)
	(envelope-from dim@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4R8cnF1qfJz43sb;
	Mon, 24 Jul 2023 11:07:13 +0000 (UTC)
	(envelope-from dim@FreeBSD.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1690196833;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CSWrTgJaLku5VhVbV1yW8lE4W9xPJkA+eKRWlOg6zpk=;
	b=SkZS/Lbg33nqwMh+r/C2G1UAf/1R2ppdy1RdNQUiu+6sN0fzr3cP48uGoFrfl2reuEbSMi
	ziuWE6ECN3l2rvtQZ0g7ZI7H7usduNl07tM6+3PJ9MsytHRjhAtuzc99+puJVoVpWGqmaw
	F3tEe3rdQRP9I4d6LuwGOGIFuf+P6ts370oQsYOJoafHnnJ2BI1Yrr0TFE1HX4eVUODs16
	NTfhCEZ6ilDlgzoPVMG7zkmDxJ7MbHJ92PTj62fBrnnjKBRSdYAreMk0wo4x0EU5mDnSic
	V8NHXUUkh2mMEiwAFP6bYhRPWVfBZrC5990pTTtsZ9rv6jVhDTaw2hlYOcP9Ng==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1690196833;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=CSWrTgJaLku5VhVbV1yW8lE4W9xPJkA+eKRWlOg6zpk=;
	b=GOyv05wGP9LogIimjsUXbsfkNYi1OI1qPW+1Tr7gOITVVkvLW3Zc5dIiGmeFU2TxjGI2fZ
	vG34H673H7txQI0o1kFpcUtUIhE4ttMLpoC06lcGJkpBHz4UWVC4CfVtoWP7E332a17DGH
	JJU1NyueMwldouZKGoyACsK/G8RnapK42qYZgp3MIHDNMiXiZN2BJ3fxRimOi3quQUV8Dw
	OTpdMTPj8YhibLZtvuCJT80pWN+9Vpa0A+IzhOeGvS3rTWyjo+DwnjB740MWlkppe1dGTU
	ov7o/GdMtOJWetrQ4W6v5gWLAha3V+6o7HBOgvHVLnVaaRBp9d80m+a/3Ttysg==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690196833; a=rsa-sha256; cv=none;
	b=QxpMVnmDRBlDX72Z8jNXmLAOsuxaizfXAsxWPHF2RWsmrqxzASZF6CY7VwxOun0/8IcqN6
	hbKw+eyAZBg8zgwrSWLuJtTqOHU8yDBmFiNKKhuM/KBIG6+HySjYkbB4APgmDWClG/AC4G
	DWwhbs3eF0N23Vawbogu7RIjLWovACdRj8eYMJFqBsqHjIjSD+tHIJsBCGVY58cNpoDgVY
	kO6kox7ACEgmSyYRpfvxmqwxNqXlfuU5gXhj6cwdvrd8qlBLkjvpZXACkIK7hNA4R0nzg5
	cfVpxV/zbTqR4PiNIXy1rEYQeHxvzpNQ2k+3AqLaSMZthX3LtEIKToP+aAZuow==
Received: from tensor.andric.com (tensor.andric.com [87.251.56.140])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "tensor.andric.com", Issuer "R3" (verified OK))
	(Authenticated sender: dim)
	by smtp.freebsd.org (Postfix) with ESMTPSA id 4R8cnF09rcz1MjP;
	Mon, 24 Jul 2023 11:07:13 +0000 (UTC)
	(envelope-from dim@FreeBSD.org)
Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by tensor.andric.com (Postfix) with ESMTPSA id 41A4A2C8E6;
	Mon, 24 Jul 2023 13:07:11 +0200 (CEST)
Content-Type: multipart/signed;
	boundary="Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E";
	protocol="application/pgp-signature";
	micalg=pgp-sha1
List-Id: Commit messages for the main branch of the src repository <dev-commits-src-main.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main
List-Help: <mailto:dev-commits-src-main+help@freebsd.org>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-main+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-main+unsubscribe@freebsd.org>
Sender: owner-dev-commits-src-main@freebsd.org
X-BeenThere: dev-commits-src-main@freebsd.org
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Subject: Re: git: 80e4ac2964a1 - main - Work around VNET and DPCPU related
 panics on aarch64
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <B059BE78-FD1A-4BA9-BA45-9FE0685C4A53@freebsd.org>
Date: Mon, 24 Jul 2023 13:06:54 +0200
Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>,
 "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>,
 "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Message-Id: <5A138CF6-8D9B-49B4-9684-BC0E76C17213@FreeBSD.org>
References: <202307232238.36NMcBxN074108@gitrepo.freebsd.org>
 <B059BE78-FD1A-4BA9-BA45-9FE0685C4A53@freebsd.org>
To: Jessica Clarke <jrtc27@freebsd.org>
X-Mailer: Apple Mail (2.3731.600.7)


--Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On 24 Jul 2023, at 00:48, Jessica Clarke <jrtc27@freebsd.org> wrote:
>=20
> On 23 Jul 2023, at 23:38, Dimitry Andric <dim@FreeBSD.org> wrote:
>>=20
>> The branch main has been updated by dim:
>>=20
>> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D80e4ac2964a11edef456a15b77e43aad=
eaf273a2
>>=20
>> commit 80e4ac2964a11edef456a15b77e43aadeaf273a2
>> Author:     Dimitry Andric <dim@FreeBSD.org>
>> AuthorDate: 2023-07-23 13:48:36 +0000
>> Commit:     Dimitry Andric <dim@FreeBSD.org>
>> CommitDate: 2023-07-23 22:35:04 +0000
>>=20
>>   Work around VNET and DPCPU related panics on aarch64
>>=20
>>   lld >=3D 14 and recent GNU ld can relax adrp+add and adrp+ldr
>>   instructions, which breaks VNET and DPCPU when used in modules.
>=20
> Thanks for committing the workaround.
>=20
> This will need some kind of EN for 13.2 given LLVM 14 was merged in
> time for that and arm64 is a Tier 1 architecture in 13.
>=20
> There perhaps also needs to be some serious thought into our testing
> and release procedures given we allowed a Tier 1 architecture to have
> VNET and DPCU be totally broken in a point release for any kernel
> module. Especially when the bug was known, open against -CURRENT and
> triaged all before the MFC to stable/13; there needs to be better
> tracking of toolchain release blockers.

I agree, but how many users does this affect? I am only a sporadic user
of aarch64 builds, but I never saw any panics, and apparently our CI
builders also do not see these.

So how often do these panics actually occur? Must you specifically use a
VNET feature to encounter them?

-Dimitry


--Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZL5bTgAKCRCwXqMKLiCW
o4aRAJ98Orz/n8qgp1Q7h91thV0dbqvv/gCguie00bHnIreg2P1kv0N2qCBewFI=
=tsMm
-----END PGP SIGNATURE-----

--Apple-Mail=_6DF64140-DD36-4E5C-8F9E-425FB1820B4E--